Maniphest T434590

Project ID not memoized
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Background

getProjectId() resp. getProjectIdByProject() ('src/ReadingListRepository.php:1556-1589') query reading_list_project on every call, and the same @local project is resolved several times per request. The table is tiny and practically immutable.

Goal

Resolve a given project to its ID at most once per request.

Acceptance criteria for done

Resolved project → rlp_id is memoized on the repository instance (optionally also via WANObjectCache).
Repeated resolutions in one request issue no extra queries (verified via the POC harness).

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	performance: Memoize project ID lookups in ReadingListRepository	VolkerE	mediawiki/extensions/ReadingLists	master	+64 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T434579 [EPIC] Improve front-end performance of ReadingLists (Saved Pages)
		Resolved		Volker_E	T434590 Project ID not memoized

Event Timeline

Volker_E created this task.Tue, Aug 11, 5:38 PM

Volker_E mentioned this in T434579: [EPIC] Improve front-end performance of ReadingLists (Saved Pages).Tue, Aug 11, 5:42 PM

Volker_E triaged this task as Medium priority.Tue, Aug 11, 8:50 PM

Change #1324395 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/ReadingLists@master] Memoize project ID lookups in ReadingListRepository

https://gerrit.wikimedia.org/r/1324395

gerritbot added a project: Patch-For-Review.Tue, Aug 11, 9:12 PM

Change #1324395 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] performance: Memoize project ID lookups in ReadingListRepository

https://gerrit.wikimedia.org/r/1324395

Maintenance_bot removed a project: Patch-For-Review.Thu, Aug 13, 3:31 PM

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.16; 2026-08-18).Thu, Aug 13, 4:00 PM

Putting directly to sign-off after @aude review/merge as this is a code-only change.

Jdlrobson-WMF moved this task from Backlog to Performance on the FY252627 Reading Lists (Graduating from Beta) board.Fri, Aug 14, 4:28 PM

aude raised the priority of this task from Medium to High.Fri, Aug 14, 5:42 PM

Jdlrobson-WMF reassigned this task from Volker_E to HFan-WMF.Thu, Aug 20, 9:16 PM

Jdlrobson-WMF subscribed.

This comment was removed by Jdlrobson-WMF.

Jdlrobson-WMF closed this task as Resolved.Thu, Aug 20, 9:17 PM

Jdlrobson-WMF reassigned this task from HFan-WMF to Volker_E.Sat, Aug 22, 1:18 AM

Jdlrobson-WMF added a subscriber: HFan-WMF.