Page MenuHomePhabricator

MinervaNeue cannot be set to the default with `minervaneue`
Closed, DuplicatePublicBUG REPORT

Description

From the support desk:

Using $wgDefaultSkin = "minervaneue"; no longer works. The screen that appears says to add wfLoadSkin( 'MinervaNeue' ); despite that already being present. It isn't until you use $wgDefaultSkin = "minerva"; that the wiki becomes usable.

image.png (1,168×456 px, 95 KB)

Event Timeline

Umherirrender subscribed.

The name of the provided skin is minerva (as defined in skin.json key ValidSkinNames), the git repo is named MinervaNeue, but that is not the name of the skin (for use in the config or the uselang= url parameter).

The installer is guessing skin name in the error message based on the name of the git repo, but that does not is correct always.

So this is a request to make the error message better? In that case this is not fixable in MinervaNeue, adding MediaWiki-Installer for the moment as well.

Or is this a request to make the string minervaneue working as config string? I would suggest a wontfix for that.

This is definitely an installer problem. On that we agree.

I thought the user might be saying that minervaneue worked in the past, but I'm not sure about that. If it did and that has changed, there is no indication of that change in the release notes.

I'd have to test, though.

Ok, tested with 1.43.9 and it is definitely an installer error.

The installer lists out the skins and says

minervaneue / MinervaNeue (disabled)

despite wfLoadSkin( 'MinervaNeue' );and $wgDefaultSkin = "minervaneue"; being in the LocalSettings.php.

Changing to $wgDefaultSkin = "minerva"; solves the problem, but doesn't follow what the error message says.

Change #1324842 had a related patch set uploaded (by MarkAHershberger; author: MarkAHershberger):

[mediawiki/core@master] SkinFallback: name the valid key for a loaded skin instead of suggesting wfLoadSkin

https://gerrit.wikimedia.org/r/1324842

Change #1324842 had a related patch set uploaded (by MarkAHershberger; author: MarkAHershberger):

[mediawiki/core@master] SkinFallback: name the valid key for a loaded skin instead of suggesting wfLoadSkin

https://gerrit.wikimedia.org/r/1324842

Change #1324842 merged by jenkins-bot:

[mediawiki/core@master] SkinFallback: name the valid key for a loaded skin instead of suggesting wfLoadSkin

https://gerrit.wikimedia.org/r/1324842

Change #1326017 had a related patch set uploaded (by MarkAHershberger; author: MarkAHershberger):

[mediawiki/core@REL1_46] SkinFallback: name the valid key for a loaded skin instead of suggesting wfLoadSkin

https://gerrit.wikimedia.org/r/1326017

Change #1326018 had a related patch set uploaded (by MarkAHershberger; author: MarkAHershberger):

[mediawiki/core@REL1_43] SkinFallback: name the valid key for a loaded skin instead of suggesting wfLoadSkin

https://gerrit.wikimedia.org/r/1326018

Change #1326017 merged by jenkins-bot:

[mediawiki/core@REL1_46] SkinFallback: name the valid key for a loaded skin instead of suggesting wfLoadSkin

https://gerrit.wikimedia.org/r/1326017

Change #1326018 merged by jenkins-bot:

[mediawiki/core@REL1_43] SkinFallback: name the valid key for a loaded skin instead of suggesting wfLoadSkin

https://gerrit.wikimedia.org/r/1326018