Page MenuHomePhabricator

Special:AbuseReview does not show revisions from deleted pages
Closed, ResolvedPublic

Description

Summary

Revisions in deleted pages are not surfaced in Special:AbuseReview, because the feature only selects rows from the revision table and does not consider the archive table

Technical details

  • The AbuseReviewPager only selects rows from the revision table. We will need to also select rows from the archive table as part of the queries, as deleted pages are not necessarily suppressed (and so may still need handling)
  • This will need to involve us making the query combine rows from multiple tables and then page on them
    • We can use the Special:CheckUser pagers as an example of this (as they combine rows from multiple tables and then page on them)

Acceptance criteria

  • Rows in the archive table with the relevant review abuse tags are shown in Special:AbuseReview

Event Timeline

Change #1325537 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/WikimediaAntiAbuse@master] Special:AbuseReview: Support showing revisions from deleted pages

https://gerrit.wikimedia.org/r/1325537

Change #1325537 merged by jenkins-bot:

[mediawiki/extensions/WikimediaAntiAbuse@master] Special:AbuseReview: Support showing revisions from deleted pages

https://gerrit.wikimedia.org/r/1325537

dom_walden subscribed.

I now see revisions from the archive table in Special:AbuseReview and I have checked that their links work.

We don't include buttons for "Suppress", "Revision delete", or "Revert only". I wonder if we should still have at least the "Suppress" button as you might still want to do that on an archived revision.

I do not see archived revisions if my user is not in the sysop group.

Thanks! I think we will want a suppress button, but the design and code for the design is changing so we can change that soon through other tickets