Page MenuHomePhabricator

Add tests coverage for the refactored DonationData() code in ComboWiki
Open, Needs TriagePublic

Description

We have introduced new code in ComboWiki.php execute() which should be heavily tested given that it departed from legacy code.

Areas to focus on are:

  • validate expected creation of contribution_tracking_id and order_id
  • validate that sequence is correctly incremented in existing legacy code and that we read it correctly from session in OrderIdHandler()
  • validate expected behavior with missing data from request (e.g. how we treat null values and set default behaviors).
  • validate we do get values from session if found and in overwirte (referrer and contribution_tracking_id) and that we don't regenerate contribution_tracking_id if found in session
  • validate the page loads regardless of errors being thrown where we don't want to interrupt but proceed silently

Event Timeline

Change #1328662 had a related patch set uploaded (by Damilare Adedoyin; author: Damilare Adedoyin):

[mediawiki/extensions/DonationInterface@master] Add more tests for combowiki payment flow

https://gerrit.wikimedia.org/r/1328662

Change #1328662 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Add more tests for combowiki payment flow

https://gerrit.wikimedia.org/r/1328662