Page MenuHomePhabricator
Create Task
Maniphest T435018

Wikinewsie footer elements misaligned on mobile view
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Open Wikinewsie on mobile view.
  • Scroll to bottom.

What happens?:

Elements are misaligned and/or cut off, both in the default state and the logged-in state.

What should have happened instead?:

Phabricator and GitLab badges should be parallel on two separate lines.

In the logged-in state, "Log out" shouldn't be cut off.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Chrome on Android.

Other information (browser name/version, screenshots, etc.):

Revisions and Commits

R3977 tool-wikinewsie
R3977:615a4791be23 T435018: Wikinewsie footer elements misaligned on mobile view

Event Timeline

Pharos created this task.Sun, Aug 16, 3:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSun, Aug 16, 3:28 AM
Pharos updated the task description. (Show Details)Sun, Aug 16, 3:28 AM
Akash_A subscribed.Sun, Aug 16, 3:07 PM
ZhaoFJx triaged this task as High priority.Sun, Aug 23, 5:45 PM
ZhaoFJx set the point value for this task to 3.
ZhaoFJx moved this task from Backlog to Triaged on the Tool-wikinewsie board.
Akash_A added a comment.Mon, Aug 24, 4:53 PM

Hello there, I tried reproducing this issue and wasn´t successful and I think I am missing something here. By referring to Wikinewsie, we are referring to the currently closed ´WikiNews´ project right?

Pharos added a comment.Mon, Aug 24, 5:52 PM

No, we are referring to the new tool hosted at https://wikinewsie.toolforge.org/

Akash_A added a comment.Mon, Aug 24, 7:11 PM

Got it, thank you. I am interested in working on this, could you provide the repo link please?

Pharos added a comment.Mon, Aug 24, 7:14 PM
In T435018#12248658, @Akash_A wrote:

Got it, thank you. I am interested in working on this, could you provide the repo link please?

Thanks, the repo is at https://gitlab.wikimedia.org/toolforge-repos/wikinewsie

Akash_A claimed this task.Mon, Aug 24, 7:25 PM

Thanks, I shall work on this particular bug then. Claiming this.

Akash_A added a comment.Mon, Aug 24, 7:57 PM

Have opened a PR, please do review and let me know if that does it.

ZhaoFJx added a commit: R3977:615a4791be23: T435018: Wikinewsie footer elements misaligned on mobile view.Tue, Aug 25, 3:13 AM
ZhaoFJx subscribed.Tue, Aug 25, 3:21 AM
In T435018#12248893, @Akash_A wrote:

Have opened a PR, please do review and let me know if that does it.

Thank you for your work! I have merged and deployed it.

ZhaoFJx closed this task as Resolved.Tue, Aug 25, 3:22 AM
ZhaoFJx moved this task from Triaged to Done on the Tool-wikinewsie board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits