Page MenuHomePhabricator

Turnilo: X-Is-Browser filter doesn't work (always HTTP 500)
Closed, ResolvedPublic

Description

This is not a timeout but a fast HTTP 500 error, both when trying to open the filter for suggestion, as well as when forcing it as a query (e.g. by using a regex).

error	"Unexpected error"
message	"match must have operand of type STRING (is NUMBER)"

Screenshot 2026-08-17 at 17.17.16.png (1,698×942 px, 207 KB)

Screenshot 2026-08-17 at 17.18.55.png (1,676×1,114 px, 204 KB)

Event Timeline

Please see also https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1305478

If there's a way we can get both split-by and filter-by to work (even if it's something gross like two different field aliases?) then that sounds great to me.

Change #1331524 had a related patch set uploaded (by Joal; author: Joal):

[operations/deployment-charts@master] Update X-is-browser webrequest_sample turnilo conf

https://gerrit.wikimedia.org/r/1331524

Change #1331524 merged by Brouberol:

[operations/deployment-charts@master] Update X-is-browser webrequest_sample turnilo conf

https://gerrit.wikimedia.org/r/1331524

Hi @CDanis and @Krinkle ,
I have added a new field X-Is-Browser score (STR) to make filtering possible in Turnilo-next: https://w.wiki/T$ar
If you're happy with that, I'll roll it out to the main turnilo as well.

Looks good to me, thanks Joseph!

Ok, applying the same new field to the main turnilo config. Thanks @CDanis .

Actually I didn't realize but my patch changed the conf for both turnilo-next and turnilo. I just applied the helm change to turnilo, no need for a new patch.