Page MenuHomePhabricator

Edit link shows on protected pages
Closed, ResolvedPublic

Description

Visit a protected page whilst logged in.
Note that the edit link appears in the top right.


Version: unspecified
Severity: normal

Details

Reference
bz41518

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:54 AM
bzimport set Reference to bz41518.

How can we check the permissions on an article? I guess we should rethink this line:

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=blob;f=javascripts/common/mf-navigation.js;h=d7a8b1eabca6ff056c5b528a03d75caf4bf7dfc6;hb=HEAD#l77

so instead of requesting an edittoken to check for whether to enable editing it checks the permissions.

This will also allow us a generic method for checking article permissions (I anticipate things like photo uploads will probably need to check whether they should run or not)