List change author in gerrit email templates
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Platonides
	Oct 31 2012, 10:44 PM

Description

When gerrit sends mails like:
«Little Red Riding Hood has posted comments on this change.» it is sometimes hard to determine if it's one of your changes (and you should act on the feedback) or you were just added as a reviewer but never even looked at it.

Please change to:
«Little Red Riding Hood has posted comments on this change by Granny.»

This is also desirable for the "has submitted this change" mails, although less important, given that they are preceded by one of the other ones.

Version: unspecified
Severity: normal

Details

Reference: bz41608

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Gerrit: Reveal the author in the title of the email	operations/puppet	production	+76 -0

Customize query in gerrit

Related Objects

Mentioned In: T288312: Gerrit notification email contains "null"

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:00 AM

• bzimport added a project: Gerrit.

• bzimport set Reference to bz41608.

• bzimport added a subscriber: Unknown Object (MLST).

Platonides created this task.Oct 31 2012, 10:44 PM

We can customize any of the e-mail templates.

Documentation is: https://gerrit.wikimedia.org/r/Documentation/config-mail.html

The customized versions are stored in the puppet repo, and we can easily add any that aren't currently customized (they're in files/gerrit/mail/)

Indeed, the $patchSetInfo variable has both author and committer values attached to it.

• demon unsubscribed.Dec 8 2014, 6:33 PM

greg lowered the priority of this task from Medium to Low.Sep 10 2015, 11:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2015, 11:05 PM

I wonder would $patchSet.author work?

Ah, {$change.ownerName} it's now possible with soy template. Can't find the code for velocity.

Change 356645 had a related patch set uploaded (by Paladox; owner: Paladox):
[operations/puppet@production] Gerrit: Reveal the author in the title of the email

https://gerrit.wikimedia.org/r/356645

gerritbot added a project: Patch-For-Review.Jun 1 2017, 6:43 PM

Paladox moved this task from Bugs & stuff to WMF customizations on the Gerrit board.Jun 6 2017, 10:37 PM

Change 356645 merged by Dzahn:
[operations/puppet@production] Gerrit: Reveal the author in the title of the email

https://gerrit.wikimedia.org/r/356645

Paladox closed this task as Resolved.Feb 3 2018, 8:14 PM

Paladox claimed this task.

Paladox removed a project: Patch-For-Review.

Paladox removed a subscriber: • wikibugs-l-list.

hashar mentioned this in T288312: Gerrit notification email contains "null".Mar 4 2022, 7:04 AM