Page MenuHomePhabricator
Create Task
Maniphest T436140

Suggestion mode pagination on mobile breaks when suggestion opens context item
Open, MediumPublic
Actions

Assigned To
medelius
Authored By
medelius
Aug 26 2026, 5:03 PM
Project Tags
Referenced Files
F107265315: 2026-10-09_09-14-23.webm
Fri, Oct 9, 3:26 PM
F107264707: 2026-10-09_09-02-30.webm
Fri, Oct 9, 3:26 PM
F107263751: 2026-10-08_10-24-56.webm
Fri, Oct 9, 3:26 PM
F101153955: DDB14B6B-F518-4975-B845-2D9E02F26586_1_102_o.jpeg
Sep 1 2026, 12:06 AM
Subscribers
Aklapper
DLynch
GMikesell-WMF
medelius
ppelberg

Description

Steps to replicate the issue (include links if applicable):

What happens?:
When you get to one of the 'Template has missing parameters' suggestions, the template context item opens immediately, getting in the way of the suggestion action card.

What should have happened instead?:
The context item should not have opened.

Example: https://youtube.com/shorts/mBWLdMcCHQ8

Derived Requirements

Ensure mobile Suggestion Mode pagination does not automatically open a context item when navigating between suggestions with the up/down arrows. When a suggestion that normally opens a context item, such as Template has missing parameters, is reached through suggestion pagination, the suggestion action card must remain unobstructed and usable.

Test Steps

Test Case 1: Verify suggestion pagination does not open a context item

  1. Open an article containing multiple suggestions, including a suggestion that opens a context item such as Template has missing parameters.
  2. Open the article in mobile VisualEditor with Suggestion Mode and Experimental Checks enabled.
  3. Select one of the available suggestions.
  4. Use the up or down navigation arrow to move through the suggestions.
  5. Continue navigating until the Template has missing parameters suggestion is reached.
  6. Verify the template context item does not open automatically.
  7. Verify the suggestion action card remains visible and unobstructed.
  8. ✅❓❌⬜ AC1: Navigating to a suggestion that normally opens a context item does not automatically open that context item, and the suggestion action card remains unobstructed.

Test Case 2: Verify suggestion pagination continues to work after reaching a context-item suggestion

  1. Open an article containing multiple suggestions, including a Template has missing parameters suggestion.
  2. Open the article in mobile VisualEditor with Suggestion Mode and Experimental Checks enabled.
  3. Select a suggestion and use the up or down navigation arrows.
  4. Navigate to the Template has missing parameters suggestion.
  5. Verify the context item does not open.
  6. Use the up or down navigation arrows again to move to another suggestion.
  7. Verify the next suggestion opens normally.
  8. ✅❓❌⬜ AC2: Suggestion pagination continues to navigate between suggestions normally after reaching a suggestion that can open a context item.

Test Case 3: Verify context items can still open when explicitly accessed

  1. Open an article containing a Template has missing parameters suggestion.
  2. Open the article in mobile VisualEditor with Suggestion Mode and Experimental Checks enabled.
  3. Navigate to the Template has missing parameters suggestion using the suggestion navigation arrows.
  4. Verify the context item does not open automatically.
  5. Explicitly select or interact with the relevant template content to open its context item.
  6. Verify the context item opens normally.
  7. ✅❓❌⬜ AC3: A context item remains available when explicitly accessed but does not open automatically during suggestion pagination.

QA Results - PROD

ACStatusDetails
1❓TT436140#12416660
2✅TT436140#12416660
3✅TT436140#12416660

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Suggestion mode: suppress context item in mobile paginationMedeliusmediawiki/extensions/VisualEditormaster+14 -1
EditCheckAction#select: don't show contexts on mobile unless requestedDLynchmediawiki/extensions/VisualEditormaster+59 -1
Customize query in gerrit

Related Objects

Event Timeline

medelius created this task.Aug 26 2026, 5:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 26 2026, 5:03 PM
Maintenance_bot added a project: VisualEditor.Aug 26 2026, 5:29 PM
ppelberg added a project: OKR-Work.Aug 26 2026, 6:21 PM
ppelberg subscribed.
DLynch subscribed.Aug 26 2026, 10:14 PM

We used to have a "don't actually do the surface selection on mobile, because it'll trigger context items / the keyboard" case, which has presumably regressed in recent refactoring.

medelius updated the task description. (Show Details)Sep 1 2026, 12:06 AM
medelius updated the task description. (Show Details)Sep 1 2026, 12:08 AM
gerritbot added a comment.Sep 1 2026, 1:52 PM

Change #1333209 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/VisualEditor@master] Suggestion mode: suppress context item in mobile pagination

https://gerrit.wikimedia.org/r/1333209

gerritbot added a project: Patch-For-Review.Sep 1 2026, 1:52 PM
medelius added a comment.Sep 1 2026, 2:03 PM
In T436140#12259704, @DLynch wrote:

We used to have a "don't actually do the surface selection on mobile, because it'll trigger context items / the keyboard" case, which has presumably regressed in recent refactoring.

I'll try to find what's changed, because not doing surface selection at all seems like a safer approach. The patch I have up now is just handling the pagination case the same way as the new dialog case (hiding any context if visible).

We also have a task T431753 for suppressing the context item entirely, on both mobile and desktop. If we want to go that route then it kinda renders this ticket moot. I'll bring it up in standup today.

ppelberg moved this task from Incoming to Ready for Dev on the Editing-team (FY2026-27 Q1 sprint 5) board.Sep 1 2026, 4:02 PM
medelius claimed this task.Sep 2 2026, 4:51 PM
medelius moved this task from Ready for Dev to Dev Doing on the Editing-team (FY2026-27 Q1 sprint 5) board.
DLynch moved this task from Incoming to Dev Doing on the Editing-team (FY2026-27 Q1 sprint 6) board.Wed, Sep 16, 4:18 PM
DLynch edited projects, added: Editing-team (FY2026-27 Q1 sprint 6); removed: Editing-team (FY2026-27 Q1 sprint 5).
ppelberg removed medelius as the assignee of this task.Wed, Sep 16, 5:22 PM
ppelberg triaged this task as Medium priority.
medelius moved this task from Dev Doing to Ready for Dev on the Editing-team (FY2026-27 Q1 sprint 6) board.Wed, Sep 16, 5:22 PM
DLynch moved this task from Ready for Dev to Code review on the Editing-team (FY2026-27 Q1 sprint 6) board.Sat, Sep 19, 11:14 PM
DLynch assigned this task to medelius.Mon, Sep 21, 4:10 PM
gerritbot added a comment.Mon, Sep 21, 10:03 PM

Change #1343646 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] EditCheckAction#select: don't show contexts on mobile unless requested

https://gerrit.wikimedia.org/r/1343646

gerritbot added a comment.Mon, Sep 21, 10:59 PM

Change #1343646 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheckAction#select: don't show contexts on mobile unless requested

https://gerrit.wikimedia.org/r/1343646

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.21; 2026-09-22).Mon, Sep 21, 11:00 PM
DLynch moved this task from Incoming to Code review on the Editing-team (FY2026-27 Q2 sprint 7) board.Wed, Sep 30, 4:50 PM
DLynch edited projects, added: Editing-team (FY2026-27 Q2 sprint 7); removed: Editing-team (FY2026-27 Q1 sprint 6).
gerritbot added a comment.Sat, Oct 3, 4:45 AM

Change #1333209 abandoned by Medelius:

[mediawiki/extensions/VisualEditor@master] Suggestion mode: suppress context item in mobile pagination

Reason:

resolved by 1343646

https://gerrit.wikimedia.org/r/1333209

Maintenance_bot removed a project: Patch-For-Review.Sat, Oct 3, 5:30 AM
DLynch moved this task from Code review to QA on the Editing-team (FY2026-27 Q2 sprint 7) board.Sat, Oct 3, 3:03 PM
DLynch added a project: Editing QA.
ppelberg moved this task from Backlog to Triaged on the VisualEditor Suggestion Mode board.Wed, Oct 7, 4:10 PM
GMikesell-WMF subscribed.Fri, Oct 9, 3:26 PM

@medelius Can you please review AC1 and the Possible issue section below?

Test Result - PROD

Status: ✅ PASS / ❓ Need More Info / ❌ FAIL
Environment: PROD
OS: macOS Tahoe 26.6.2
Browser: Chrome 153
Device: MBA
Emulated Device: Developer Tools- Pixel 10, iPad 13 Pro, Galaxy Z Fold 6
Test Artifact(s):

Test Steps

Test Case 1: Verify suggestion pagination does not open a context item

  1. Open an article containing multiple suggestions, including a suggestion that opens a context item such as Template has missing parameters.
  2. Open the article in mobile VisualEditor with Suggestion Mode and Experimental Checks enabled.
  3. Select one of the available suggestions.
  4. Use the up or down navigation arrow to move through the suggestions.
  5. Continue navigating until the Template has missing parameters suggestion is reached.
  6. Verify the template context item does not open automatically.
  7. Verify the suggestion action card remains visible and unobstructed.
  8. ❓ AC1: Navigating to a suggestion that normally opens a context item does not automatically open that context item, and the suggestion action card remains unobstructed.
  • Just to clarify the behavior: The Template has missing parameters suggestion displays correctly. When I click Edit, the Template content panel opens. Then, without any further interaction, the content form automatically appears about 8 seconds later.
Pixel 10

Test Case 2: Verify suggestion pagination continues to work after reaching a context-item suggestion

  1. Open an article containing multiple suggestions, including a Template has missing parameters suggestion.
  2. Open the article in mobile VisualEditor with Suggestion Mode and Experimental Checks enabled.
  3. Select a suggestion and use the up or down navigation arrows.
  4. Navigate to the Template has missing parameters suggestion.
  5. Verify the context item does not open.
  6. Use the up or down navigation arrows again to move to another suggestion.
  7. Verify the next suggestion opens normally.
  8. ✅ AC2: Suggestion pagination continues to navigate between suggestions normally after reaching a suggestion that can open a context item.
iPad 13 Pro
2026-10-09_09-02-30.webm0 BDownload

Test Case 3: Verify context items can still open when explicitly accessed

  1. Open an article containing a Template has missing parameters suggestion.
  2. Open the article in mobile VisualEditor with Suggestion Mode and Experimental Checks enabled.
  3. Navigate to the Template has missing parameters suggestion using the suggestion navigation arrows.
  4. Verify the context item does not open automatically.
  5. Explicitly select or interact with the relevant template content to open its context item.
  6. Verify the context item opens normally.
  7. ✅ AC3: A context item remains available when explicitly accessed but does not open automatically during suggestion pagination.

See AC1

❓ Possible Issue

Galaxy Z Fold 6
GMikesell-WMF updated the task description. (Show Details)Fri, Oct 9, 3:28 PM
GMikesell-WMF moved this task from QA to Ready for Dev on the Editing-team (FY2026-27 Q2 sprint 7) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits