Page MenuHomePhabricator

Separating combinable and distinct case filters
Closed, ResolvedPublic

Description

All "Account activity" filters will filter for cases that match any of the given criteria. There is no way to filter for a specific combination of criteria. As an MVP, split the filters that should be combinable into their own section. This will support being able to filter for cases with "edits and blocks."

CurrentUpdated
image.png (440×127 px, 19 KB)
image.png (263×245 px, 19 KB)

Acceptance Criteria:

  • Remove the edits/blocks filters from the account activity section
    • As of writing, the screenshot shows multiple filters remaining in the "Account activity" section but only "Overlapping edits" has been implemented. The other filters are not part of this task.
  • Add a new section targeting these filters
  • Add a radio into that allows the user to select any combination of edits/blocks on accounts
  • Update copy
  • Instrumentation for the selection of the filter, using the applied_filters

Event Timeline

Change #1333917 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@master] Split out edit and block-based filters from activity filters

https://gerrit.wikimedia.org/r/1333917

Change #1333917 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Split out edit and block-based filters from activity filters

https://gerrit.wikimedia.org/r/1333917

Change #1337610 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@wmf/1.47.0-wmf.18] Split out edit and block-based filters from activity filters

https://gerrit.wikimedia.org/r/1337610

Change #1337610 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@wmf/1.47.0-wmf.18] Split out edit and block-based filters from activity filters

https://gerrit.wikimedia.org/r/1337610

Mentioned in SAL (#wikimedia-operations) [2026-09-08T13:10:01Z] <stran@deploy1003> Started scap sync-world: Backport for [[gerrit:1337610|Split out edit and block-based filters from activity filters (T436508)]]

Mentioned in SAL (#wikimedia-operations) [2026-09-08T13:29:57Z] <stran@deploy1003> stran: Backport for [[gerrit:1337610|Split out edit and block-based filters from activity filters (T436508)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-09-08T13:44:01Z] <stran@deploy1003> Finished scap sync-world: Backport for [[gerrit:1337610|Split out edit and block-based filters from activity filters (T436508)]] (duration: 34m 00s)

@STran Shouldn't the default be "Not required"? Right now it seems contradictory- on one hand, the default is edits, but on the other hand it shows a "1" on the filters button, as if I had set a personal filter...

@neriah This doesn't change the underlying behavior of SuggestedInvestigations, which hid cases without edits by default and represented it by leaving the checkbox "Show accounts without edits" unchecked. This normalized all filters to filtering for something so because it filters by edits by default, that means that filter is active by default. If you change it to 'none', the filter count will drop to 0.

I believe the filter count should only count filters that have been changed, and therefore shouldn't count the default as a filter. but that's your decision to make..

I believe the filter count should only count filters that have been changed

+1

Change #1341349 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/CheckUser@master] SI: Exclude default filter from active filter count

https://gerrit.wikimedia.org/r/1341349

Resolving this as the main feature ask has been implemented. Discussion about infochip behavior should happen at T437978: Decide filter count infochip behavior.