Page MenuHomePhabricator

Deprecate SiteStore, prefer SiteLookup (😾)
Closed, ResolvedPublic

Description

The Wikimedia wiki farm has a static list of active sites, consumers of this list will be reading from but never writing to this list. Convert all usages of getSiteStore to use getSiteLookup instead.

  • Extension:CampaignEvents -> test only, can replace with a mock
  • Extension:CentralAuth -> test only, can replace with a mock
  • Extension:GlobalBlocking -> test only, can replace with a mock
  • Extension:GrowthExperiments -> looks up the language code for a given project ID
  • Extension:Wikibase -> already using the restricted SiteLookup sub-interface, the service call can be adjusted safely
  • Deprecate MediaWikiServices::getSiteStore
  • Maintenance scripts adjusting the sites table -> these will become unnecessary *(won't do on this task)

To follow up in separate work: the core class TestSites seems to be unused now.

Event Timeline

Change #1332727 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/CampaignEvents@master] Switch to SiteLookup

https://gerrit.wikimedia.org/r/1332727

Change #1332732 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/CentralAuth@master] Mock SiteStore

https://gerrit.wikimedia.org/r/1332732

Change #1332737 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/GlobalBlocking@master] Mock SiteStore

https://gerrit.wikimedia.org/r/1332737

Change #1332740 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/GrowthExperiments@master] Switch to SiteLookup

https://gerrit.wikimedia.org/r/1332740

Change #1332742 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Wikibase@master] Remove unused SiteStore in tests

https://gerrit.wikimedia.org/r/1332742

Change #1332744 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Wikibase@master] Switch to SiteLookup

https://gerrit.wikimedia.org/r/1332744

Change #1332732 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Mock SiteStore

https://gerrit.wikimedia.org/r/1332732

Change #1332737 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Mock SiteStore

https://gerrit.wikimedia.org/r/1332737

Change #1332727 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Mock SiteLookup in test

https://gerrit.wikimedia.org/r/1332727

Change #1332744 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Switch to SiteLookup

https://gerrit.wikimedia.org/r/1332744

Change #1332742 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Mock site store without touching database

https://gerrit.wikimedia.org/r/1332742

Virginie.caplet renamed this task from Deprecate SiteStore, prefer SiteLookup to Deprecate SiteStore, prefer SiteLookup (😾).Mon, Sep 7, 10:11 AM

Change #1341720 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/core@master] Mark the SiteStore service as deprecated

https://gerrit.wikimedia.org/r/1341720

Change #1341720 merged by jenkins-bot:

[mediawiki/core@master] Mark the SiteStore service as deprecated

https://gerrit.wikimedia.org/r/1341720

Change #1332740 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Switch to SiteLookup

https://gerrit.wikimedia.org/r/1332740