Page MenuHomePhabricator

Install PHP xdiff extension on gallium (PHPUnit skipping tests)
Closed, DeclinedPublic

Description

Right now we're skipping some tests since we don't have xdiff available to us. See for example: https://integration.mediawiki.org/ci/job/MediaWiki-Tests-Databaseless/8596/console

IIRC, it has to be done by hand, though. Install libxdiff, then compile the pecl extension.

http://www.xmailserver.org/xdiff-lib.html
http://www.php.net/manual/en/intro.xdiff.php


Version: wmf-deployment
Severity: minor

Details

Reference
bz41683

Event Timeline

bzimport raised the priority of this task from to Lowest.
bzimport set Reference to bz41683.
bzimport added a subscriber: Unknown Object (MLST).
demon created this task.Nov 2 2012, 10:58 AM

We need to have the extension packages for Precise and uploaded to WMF apt repository. Can be done via some Debian helping script which creates packages out of pecl. Will poke ops about it.

hashar added a comment.Dec 3 2012, 7:43 AM

Low priority, we do not use that extension on the cluster and most people do not have it anyway.

lcarr wrote:

If someone can package this for precise, we would be happy to install.

demon added a comment.Apr 18 2013, 6:50 PM

Considering we don't use this ourselves, and very few third party users use it either, marking lowest priority.

(I'm wondering if we even need the feature at all, but that'd be another bug)

I looked a bit at it. That requires libxdiff which is not packaged. I dont think we should invest any time on that.

If we do not use xdiff, we might want to fill another bug to remove xdiff from MediaWiki core.

lcarr wrote:

+1

(In reply to comment #5)

I looked a bit at it. That requires libxdiff which is not packaged. I dont
think we should invest any time on that.

If we do not use xdiff, we might want to fill another bug to remove xdiff
from
MediaWiki core.

xdiff is used in mw/core by maintenance/storage/recompressTracked.php Maybe we can find out a way to completely hide the skipped tests in Jenkins

  • Bug 68642 has been marked as a duplicate of this bug. ***

Probably nobody is going to package libxdiff / php-xdiff so we can get installed so I am closing this bug. If there is anyone willing to actually handle the packaging grunt work and have the result uploaded on apt.wikimedia.org, it would then be trivial to have the PHP module on Jenkins servers.

Change 253534 had a related patch set uploaded (by Krinkle):
phpunit: Omit long xdiff test provider from Jenkins output

https://gerrit.wikimedia.org/r/253534

Change 253534 merged by jenkins-bot:
phpunit: Omit long xdiff test provider from Jenkins output

https://gerrit.wikimedia.org/r/253534