Page MenuHomePhabricator

Local BlockUserTest failures due to Echo hooks
Closed, ResolvedPublic

Description

Various test cases in BlockUserTest fail locally due to Echo, for instance:

1) MediaWiki\Tests\Integration\Block\BlockUserTest::testValidTarget
Wikimedia\NormalizedException\NormalizedException: Invalid IP agent: Unknown user for event type user-blocked

/var/www/html/w/extensions/Echo/includes/Model/Event.php:724
/var/www/html/w/extensions/Echo/includes/Model/Event.php:170
/var/www/html/w/extensions/Echo/includes/EchoNotificationHandler.php:37
/var/www/html/w/includes/Notification/NotificationService.php:99
/var/www/html/w/extensions/Echo/includes/Hooks.php:654
/var/www/html/w/includes/HookContainer/HookContainer.php:127
/var/www/html/w/includes/HookContainer/HookRunner.php:1121
/var/www/html/w/includes/Block/BlockUser.php:667
/var/www/html/w/includes/Deferred/MWCallableUpdate.php:52
/var/www/html/w/includes/Deferred/DeferredUpdates.php:448
/var/www/html/w/includes/Deferred/DeferredUpdates.php:187
/var/www/html/w/includes/Deferred/DeferredUpdates.php:277
/var/www/html/w/includes/Deferred/DeferredUpdatesScope.php:229
/var/www/html/w/includes/Deferred/DeferredUpdatesScope.php:158
/var/www/html/w/includes/Deferred/DeferredUpdates.php:271
/var/www/html/w/includes/Deferred/DeferredUpdates.php:363
/var/www/html/w/includes/Deferred/DeferredUpdates.php:142
/var/www/html/w/includes/Deferred/DeferredUpdates.php:165
/var/www/html/w/includes/Block/BlockUser.php:666
/var/www/html/w/includes/Block/BlockUser.php:560
/var/www/html/w/includes/Block/BlockUser.php:485
/var/www/html/w/tests/phpunit/integration/includes/Block/BlockUserTest.php:46

Details

Event Timeline

This seems like a problem with BlockUserTest, it shouldn't place a block with a performer that doesn't exist.

Change #1337623 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] BlockUserTest: do not use nonexistent performer

https://gerrit.wikimedia.org/r/1337623

Dreamy_Jazz subscribed.

Adding Product Safety and Integrity sprint as we are providing code review (so we can track the code review). Thanks for the patch

Change #1337623 merged by jenkins-bot:

[mediawiki/core@master] BlockUserTest: do not use nonexistent performer

https://gerrit.wikimedia.org/r/1337623