Page MenuHomePhabricator
Create Task
Maniphest T437134

Run only the PHPUnit Database tests in the sqlite and postgres core jobs to speed up the gated pipeline
Closed, ResolvedPublic
Actions

Description

Today the quibble-for-mediawiki-core-vendor-sqlite-php83 and quibble-for-mediawiki-core-vendor-postgres-php83 run the full PHP test suite event though that the reason for this tests is to test different database backends. We could remove running the PHPUnit tests suite that do not use the database, the QUnit tests (and then also the npm install phase). Those tests already runs in the quibble-for-mediawiki-core-vendor-mysql-php83 job.

If we do this change this will make the jobs 2-3 minutes faster (depending on how much load that are on the server when they run).

Acceptance Criteria:

  • Remove the PHPUnit without database tests from the SQLite and Postgres job
  • Remove the QUnit tests and make sure we don't run npm install for those jobs
  • When this is released, clear the Castor cache for the jobs to get rid of the node dependencies

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
jjb: Run only database tests in the sqlite and postgres core jobsPhedenskogintegration/configmaster+8 -1
jjb: update Quibble jobs for 1.21.0Hasharintegration/configmaster+33 -33
release: Quibble 1.21.0Hasharintegration/quibblemaster+23 -8
Allow running only the PHPUnit tests that need a databasePhedenskogintegration/quibblemaster+61 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

Peter created this task.Sep 5 2026, 9:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 5 2026, 9:32 AM
Peter updated the task description. (Show Details)Sep 5 2026, 9:32 AM
Peter claimed this task.Sep 6 2026, 10:19 AM
Peter edited projects, added: Test Platform (Arusha 30); removed: Test Platform.

T436448 should also be fixed.

gerritbot added a comment.Sep 7 2026, 5:14 AM

Change #1337436 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[integration/quibble@master] Allow running only the PHPUnit tests that need a database

https://gerrit.wikimedia.org/r/1337436

gerritbot added a project: Patch-For-Review.Sep 7 2026, 5:14 AM
gerritbot added a comment.Sep 7 2026, 5:19 AM

Change #1337437 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[integration/config@master] jjb: Run only database tests in the sqlite and postgres core jobs

https://gerrit.wikimedia.org/r/1337437

gerritbot added a comment.Sep 7 2026, 2:14 PM

Change #1337436 merged by jenkins-bot:

[integration/quibble@master] Allow running only the PHPUnit tests that need a database

https://gerrit.wikimedia.org/r/1337436

Peter moved this task from Backlog to Finishing Touches on the Test Platform (Arusha 30) board.Sep 8 2026, 6:53 AM
gerritbot added a comment.Sep 8 2026, 2:47 PM

Change #1337943 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/quibble@master] release: Quibble 1.21.0

https://gerrit.wikimedia.org/r/1337943

gerritbot added a comment.Sep 8 2026, 3:04 PM

Change #1337943 merged by jenkins-bot:

[integration/quibble@master] release: Quibble 1.21.0

https://gerrit.wikimedia.org/r/1337943

Stashbot mentioned this in T300727: Rename cmd.py to distinguish from Command.Sep 8 2026, 3:06 PM
Stashbot mentioned this in T429715: Upgrade Quibble code base to Python3.11.

Mentioned in SAL (#wikimedia-releng) [2026-09-08T15:06:15Z] <hashar> Tag Quibble @ b692707e5213abf5e16894b1fb21cea41cd72c9e # T429715 T303270 T437134 T300727

Stashbot mentioned this in T303270: Parallel npm install times out in Quibble.Sep 8 2026, 3:06 PM
gerritbot added a comment.Sep 8 2026, 3:09 PM

Change #1337949 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update Quibble jobs for 1.21.0

https://gerrit.wikimedia.org/r/1337949

Stashbot added a comment.Sep 8 2026, 3:42 PM

Mentioned in SAL (#wikimedia-releng) [2026-09-08T15:42:23Z] <hashar> Updating Quibble jobs to 1.21.0 # T429715 T303270 T437134 T300727

gerritbot added a comment.Sep 8 2026, 3:53 PM

Change #1337949 merged by jenkins-bot:

[integration/config@master] jjb: update Quibble jobs for 1.21.0

https://gerrit.wikimedia.org/r/1337949

Peter added a parent task: T437452: Get the gate-and-submit pipeline feedback loop p75 for core below 10 minute.Sep 9 2026, 1:47 PM
gerritbot added a comment.Sep 10 2026, 5:49 AM

Change #1337437 merged by jenkins-bot:

[integration/config@master] jjb: Run only database tests in the sqlite and postgres core jobs

https://gerrit.wikimedia.org/r/1337437

Stashbot added a comment.Sep 10 2026, 5:49 AM

Mentioned in SAL (#wikimedia-releng) [2026-09-10T05:49:05Z] <phedenskog> Updated quibble-for-mediawiki-core postgres and sqlite jobs to run only the phpunit-database stage T437134

Peter added a comment.Sep 10 2026, 6:13 AM

This is what the data looks like before the change:

Screenshot 2026-09-10 at 08.11.45.png (3,080×908 px, 342 KB)

Maintenance_bot removed a project: Patch-For-Review.Sep 10 2026, 6:30 AM
AMarkossyan-WMF subscribed.Sep 10 2026, 11:26 AM

A quick question on this: does it make sense to eventually move these tests to a completely separate job? Because, based on this task, these non-database tests are running in the MySQL job, which is also supposed to only run database tests and not QUnit and other unit tests.

Peter mentioned this in T437452: Get the gate-and-submit pipeline feedback loop p75 for core below 10 minute.Sep 10 2026, 12:09 PM
Peter added a comment.Sep 10 2026, 6:37 PM

Because, based on this task, these non-database tests are running in the MySQL

Yep I agree that makes sense.

Peter closed this task as Resolved.Sep 11 2026, 5:03 AM
Peter moved this task from Finishing Touches to Done on the Test Platform (Arusha 30) board.

We need to run this for a longer time but for one day the p75 went from 13:16 to 10:08.

Peter mentioned this in T437796: Postgres job time increased by 8 minutes after a while when the database less PHP jobs was removed.Sep 13 2026, 5:26 AM
pwangai mentioned this in T438110: quibble-for-mediawiki-core-vendor-postgres-php83 is ~3x slower since 2026-09-11.Wed, Sep 16, 4:40 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits