Page MenuHomePhabricator

Ensure Wikidata descriptions are added to edits in all Review Changes sources
Closed, ResolvedPublic3 Estimated Story Points

Description

Background

In r1325200 (T422148) I inadvertently removed Wikidata descriptions from being added to the new "recently-edited" source for the Review Changes feed. This needs to be added back.

Technical notes

Given T436570: PersonalDashboard: Shared feed REST API for the dashboard feed scaffold is in-flight, it probably makes the most sense to tag this on to the end of that relation chain, rather than patch what we have in the interim. The only cost is that in the meantime, some edits that show up in Review Changes won't have descriptions – not deemed a huge problem (correct me if I'm wrong, though!).

While Extension:ShortDescription exists to make local testing easier, the mechanisms for fetching the description server-side is different than WikiBase.

Acceptance criteria

  • Use the WikibaseClient.DescriptionLookup service to fetch the description.
    • Bonus points: fallback to looking for a shortdesc page prop to make local testing with Extension:ShortDescription easier, and for other MW installations that may use it instead of WikiBase
  • All changes in the Review Changes feed should show descriptions (assuming they are present)

Event Timeline

MusikAnimal changed the task status from Open to Stalled.
MusikAnimal changed the task status from Stalled to In Progress.Sep 9 2026, 6:01 PM
MusikAnimal moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
MusikAnimal renamed this task from Ensure Wikidata descriptions are added to all Review Changes sources to Ensure Wikidata descriptions are added to edits in all Review Changes sources.Sep 9 2026, 6:05 PM

Change #1338297 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/PersonalDashboard@master] Ensure page descriptions are included in all ChangesListFeedSources

https://gerrit.wikimedia.org/r/1338297

Change #1338299 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[integration/config@master] zuul: add ORES and Wikibase as phan dependency of PersonalDashboard

https://gerrit.wikimedia.org/r/1338299

Change #1338299 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/PersonalDashboard] Add ORES & Wikibase phan deps

https://gerrit.wikimedia.org/r/1338299

Mentioned in SAL (#wikimedia-releng) [2026-09-10T18:56:18Z] <James_F> Zuul: [mediawiki/extensions/PersonalDashboard] Add ORES & Wikibase phan deps for T436570 and T437491

MusikAnimal set the point value for this task to 3.Tue, Sep 15, 4:10 PM
jsn.sherman changed the point value for this task from 3 to 5.

Change #1338297 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] Ensure page descriptions are included in all ChangesListFeedSources

https://gerrit.wikimedia.org/r/1338297

jsn.sherman changed the point value for this task from 5 to 3.

Change #1342686 had a related patch set uploaded (by Dillon; author: Dillon):

[mediawiki/extensions/PersonalDashboard@master] ReviewChanges: read the feed from the REST endpoint

https://gerrit.wikimedia.org/r/1342686

Change #1342686 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] ReviewChanges: read the feed from the REST endpoint

https://gerrit.wikimedia.org/r/1342686

MusikAnimal moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.

Confirmed on testwiki via the SHORTDESC parser function provided by Wikibase.