Page MenuHomePhabricator
Create Task
Maniphest T437607

Implementation of consolidating the data from SiteMatrix and site_identifiers for SiteLookup
Closed, ResolvedPublic
Actions

Description

As per our discussion, this would be the implementation of the EPIC.

I will update the ticket based on what we discussed in a while.

Properties which need to be copied into the Site object:

  • globalId
  • type - always "mediawiki"
  • group
  • source - always "local"
  • languageCode - from SiteMatrix and per-wiki $wgLanguageCode
  • localIds - algorithmically added where needed: on languages of the same project group; and on specials
  • extraData - set fixed paths <url>/w/$1 and <url>/wiki/$1. Url is from per-wiki $wgCanonicalServer
  • extraConfig - always empty [] (deprecated)
  • forward - always false (deprecated)
  • internalId - this needs to be removed, there will be no database ID. (deprecated)

Details

Other Assignee
awight
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Get SiteLookup based on configuration settings so that other wiki farms can use their own implementation.Seanleong-wmdemediawiki/coremaster+37 -4
Deprecate Site internalIdAwightmediawiki/coremaster+5 -0
Use explicit typing for SiteStore and SiteLookupAwightmediawiki/coremaster+28 -40
SiteLookup implementation for getting data from SiteMatrixSeanleong-wmdemediawiki/extensions/SiteMatrixmaster+370 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

seanleong-WMDE created this task.Thu, Sep 10, 2:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Sep 10, 2:45 PM
gerritbot added a comment.Thu, Sep 10, 2:46 PM

Change #1338952 had a related patch set uploaded (by Seanleong-wmde; author: Seanleong-wmde):

[mediawiki/extensions/SiteMatrix@master] [WIP] SiteMatrixLookup implementation for getting data from SiteMatrix

https://gerrit.wikimedia.org/r/1338952

gerritbot added a project: Patch-For-Review.Thu, Sep 10, 2:46 PM
gerritbot added a comment.Thu, Sep 10, 3:42 PM

Change #1338974 had a related patch set uploaded (by Seanleong-wmde; author: Seanleong-wmde):

[mediawiki/core@master] Get SiteLookup based on configuration settings so that other wiki farms can use their own implementation.

https://gerrit.wikimedia.org/r/1338974

Krinkle subscribed.Fri, Sep 11, 9:13 AM
Tacsipacsi subscribed.Sun, Sep 13, 12:26 PM
awight moved this task from In Preparation to In Progress (+ sprint emoji to the title on entry) WIP = 4 on the Wikidata Integration in Wikimedia projects (Goals Board) board.Wed, Sep 16, 9:35 AM
awight updated Other Assignee, added: awight.Wed, Sep 16, 9:39 AM
awight updated the task description. (Show Details)
gerritbot added a comment.Wed, Sep 16, 9:59 AM

Change #1342202 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/core@master] Use explicit typing for SiteStore and SiteLookup

https://gerrit.wikimedia.org/r/1342202

awight updated the task description. (Show Details)Wed, Sep 16, 11:22 AM
awight updated the task description. (Show Details)Wed, Sep 16, 12:01 PM
gerritbot added a comment.Wed, Sep 16, 12:12 PM

Change #1342242 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/core@master] Deprecate Site internalId

https://gerrit.wikimedia.org/r/1342242

gerritbot added a comment.Wed, Sep 16, 1:28 PM

Change #1342202 merged by jenkins-bot:

[mediawiki/core@master] Use explicit typing for SiteStore and SiteLookup

https://gerrit.wikimedia.org/r/1342202

gerritbot added a comment.Wed, Sep 16, 1:33 PM

Change #1342242 merged by jenkins-bot:

[mediawiki/core@master] Deprecate Site internalId

https://gerrit.wikimedia.org/r/1342242

gerritbot added a comment.Wed, Sep 16, 1:48 PM

Change #1338952 merged by jenkins-bot:

[mediawiki/extensions/SiteMatrix@master] SiteLookup implementation for getting data from SiteMatrix

https://gerrit.wikimedia.org/r/1338952

awight moved this task from In Progress (+ sprint emoji to the title on entry) WIP = 4 to In Review / Comms + AC Testing on the Wikidata Integration in Wikimedia projects (Goals Board) board.Wed, Sep 16, 1:53 PM
awight updated the task description. (Show Details)Wed, Sep 16, 1:58 PM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.21; 2026-09-22).Wed, Sep 16, 2:00 PM
Tacsipacsi added a comment.Fri, Sep 18, 5:18 PM
  • forward - always false (deprecated)

As I wrote in T431093#12292626, I believe it should be always true, at least in the SiteMatrix implementation. Also, I wouldn’t deprecate it without surveying other providers; maybe other farms are more restrictive with link forwarding (WMF is a relatively small and trusted wiki farm compared to free hosting services like Miraheze and Fandom, so what we trust is not the same as what everyone trusts).

awight added a parent task: T438841: Beta cluster wikidata sitelinks are wrong.Tue, Sep 22, 1:02 PM
gerritbot added a comment.Tue, Sep 22, 1:43 PM

Change #1338974 merged by jenkins-bot:

[mediawiki/core@master] Get SiteLookup based on configuration settings so that other wiki farms can use their own implementation.

https://gerrit.wikimedia.org/r/1338974

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.22; 2026-09-29); removed: MW-1.47-notes (1.47.0-wmf.21; 2026-09-22).Tue, Sep 22, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Tue, Sep 22, 2:32 PM
awight moved this task from In Review / Comms + AC Testing to Done ( wit. set to "resolved" after prod / comm / ac testing) on the Wikidata Integration in Wikimedia projects (Goals Board) board.Wed, Sep 23, 8:07 AM
seanleong-WMDE closed this task as Resolved.Wed, Sep 23, 10:46 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits