Page MenuHomePhabricator
Create Task
Maniphest T437719

BookmarkBloomFilterCacheTest::testGetBloomFilterStatus_returnsUnusableStateWhenCachedPayloadHasNoState: Failed asserting that false is an instance of class "StatusValue"
Closed, ResolvedPublic
Actions

Description

Seen this failure twice in CirrusSearch CI in one day (https://integration.wikimedia.org/ci/job/quibble-with-gated-extensions-vendor-mysql-php83/56271/ & https://integration.wikimedia.org/ci/job/quibble-with-gated-extensions-vendor-mysql-php83/56341/)

11:02:09 Report from `split_group3`:
11:02:09 
11:02:09 There was 1 failure:
11:02:09 
11:02:09 1) MediaWiki\Extension\ReadingLists\Tests\Unit\Service\BookmarkBloomFilterCacheTest::testGetBloomFilterStatus_returnsUnusableStateWhenCachedPayloadHasNoState
11:02:09 Failed asserting that false is an instance of class "StatusValue".
11:02:09 
11:02:09 /workspace/src/extensions/ReadingLists/tests/phpunit/unit/Service/BookmarkBloomFilterCacheTest.php:208

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
tests: Fix flaky BookmarkBloomFilterCacheTestAudemediawiki/extensions/ReadingListsmaster+50 -17
Customize query in gerrit

Event Timeline

dcausse created this task.Sep 11 2026, 2:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 11 2026, 2:40 PM
dcausse added a project: ci-test-error.Sep 11 2026, 2:41 PM
dcausse added a project: Reader Experience Team.Sep 11 2026, 2:44 PM
siebrand triaged this task as High priority.Sep 12 2026, 11:33 AM
siebrand subscribed.

Also seen multiple times in Translate tests. Appears to be intermittent. Example: https://integration.wikimedia.org/ci/job/quibble-with-gated-extensions-vendor-mysql-php83/56679/console

13:22:10 Some split_groups failed - returning failure status
13:22:10 Summarizing parallel error logs for databaseless group...
13:22:10 
13:22:10 
13:22:10 Report from `split_group3`:
13:22:10 
13:22:10 There was 1 failure:
13:22:10 
13:22:10 1) MediaWiki\Extension\ReadingLists\Tests\Unit\Service\BookmarkBloomFilterCacheTest::testGetBloomFilterStatus_returnsUnusableStateWhenCachedPayloadHasNoState
13:22:10 Failed asserting that false is an instance of class "StatusValue".
13:22:10 
13:22:10 /workspace/src/extensions/ReadingLists/tests/phpunit/unit/Service/BookmarkBloomFilterCacheTest.php:208
Tacsipacsi subscribed.Sep 12 2026, 6:14 PM

The test in question is reading from a cache, so the flakiness is clearly due to sometimes having cache hits (the test passes), sometimes having cache misses (it fails).

A wild guess: maybe different test cases use the same cache, and depending on the timing, one test case may erase the cache entry that the other one is expecting to see?

gerritbot added a comment.Sep 14 2026, 6:53 PM

Change #1341321 had a related patch set uploaded (by Aude; author: Aude):

[mediawiki/extensions/ReadingLists@master] tests: Fix flaky BookmarkBloomFilterCacheTest

https://gerrit.wikimedia.org/r/1341321

gerritbot added a project: Patch-For-Review.Sep 14 2026, 6:53 PM
aude claimed this task.Sep 14 2026, 6:57 PM
Jdlrobson-WMF moved this task from Incoming to Backlog on the Reader Experience Team board.Wed, Sep 16, 11:39 PM
gerritbot added a comment.Sat, Sep 19, 8:16 AM

Change #1341321 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] tests: Fix flaky BookmarkBloomFilterCacheTest

https://gerrit.wikimedia.org/r/1341321

Umherirrender closed this task as Resolved.Sat, Sep 19, 8:19 AM
Umherirrender removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.21; 2026-09-22).Sat, Sep 19, 9:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits