Hi, I’ve finished working on T437754 and submitted the changes to Gerrit for review.

Gerrit Change: 1340539

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/1340539

The patch adds comment author/text indexing, the commentby: search option, same-comment matching for the author and text, and the related unit tests. It’s now up for CI and review.

@Shivang9856 Thanks for the patch. Please follow https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines and correct your commit message. After that, no manually added comments on tasks about Gerrit patches will be needed anymore.

Adding DiscussionTools, my understanding is that this data is "owned" by this extension and thus should also own the search logic behind it.
There should be some estimate about the expected volume and cost before moving forward.

Following-up here based on discussions on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/1340539.
General guidelines:

• CirrusSearch should not depend on DiscussiontTools, since the data is "owned" by DiscussiontTools the mapping, the SearchDataForIndex2 hook and the search keyword implementation should be added to DiscussiontTools. This means that DiscussionTools will depend on CirrusSearch and probably something that needs agreement from the DiscussionTools maintainers.
• nested fields should be avoided, I understand the need for nested field if we want to perfectly match the comment text and its author but given the ticket description I am not clear if this is a strong requirement, for instance would filtering by author be already sufficient to narrow down the search space? Specific examples would greatly help I think here. If there are possible workarounds we should probably explore them first.

Cost:

• size: if ultimately splitting the comments and attaching them to their author is a necessity we have to estimate the added cost on the search index. Search index documents already contain two copies of the text (the wikitext + the parsed text), this would add a third copy of the text for all discussion pages where DiscussionTools is installed.
• compute: extracting this information will require calling DiscussionTools on every talk page update. The search index is updated from 3 different sources: page edits, page rerenders, and consistency checks, we have to estimate the update rate on discussion pages and verify that the added cost of calling the DiscussionTools parser is acceptable for the WMF mediawiki cluster.