Page MenuHomePhabricator
Create Task
Maniphest T437764

Strike text wrapped in <s> and <strike> tags in CodeMirror
Closed, ResolvedPublicFeature
Actions

Description

Feature summary (what you would like to be able to do and where):
Text wrapped in these HTML tags should be struck (<s> and <strike>) in CodeMirror Syntax Highlighting.

Use case(s) and Benefits (Describe the actual underlying problem which you want to solve. Why should this be implemented? Do not describe only a solution):
This would make it clearer to users which text is struck in the wikitext editor.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
codemirror.visualEditorHighlight.less: strikethroughBhsdmediawiki/extensions/CodeMirrormaster+4 -0
Add strikethrough styling for <s> and <strike> HTML tagsAkaza24mediawiki/extensions/CodeMirrormaster+87 -9
Customize query in gerrit

Related Objects

Event Timeline

Axolitl created this task.Sep 12 2026, 4:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2026, 4:12 AM
Axolitl mentioned this in T437763: Italicize/bold text wrapped in <b>, <strong>, <i>, and <em> tags in CodeMirror.Sep 12 2026, 4:13 AM
MusikAnimal moved this task from Backlog to Improvement on the MediaWiki-extensions-CodeMirror board.Sep 12 2026, 6:10 AM
Bhsd subscribed.Sep 12 2026, 3:52 PM

Underlines will be ambiguous because they are also used to mark links.

Axolitl added a comment.Sep 12 2026, 4:11 PM
In T437764#12314478, @Bhsd wrote:

Underlines will be ambiguous because they are also used to mark links.

By default, yes (although that can be disabled in preferences) but links already have formatting in CodeMirror, being pretty clearly a link.

Akaza24 subscribed.Sep 12 2026, 9:15 PM
gerritbot added a comment.Sep 12 2026, 9:37 PM

Change #1340535 had a related patch set uploaded (by Akaza24; author: Akaza24):

[mediawiki/extensions/CodeMirror@master] Add underline and strikethrough styling for HTML tags

https://gerrit.wikimedia.org/r/1340535

gerritbot added a project: Patch-For-Review.Sep 12 2026, 9:37 PM
Bhsd changed the task status from Open to In Progress.Thu, Oct 1, 12:06 AM
Bhsd assigned this task to Akaza24.
gerritbot added a comment.Thu, Oct 1, 11:45 PM

Change #1340535 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Add strikethrough styling for <s> and <strike> HTML tags

https://gerrit.wikimedia.org/r/1340535

Maintenance_bot removed a project: Patch-For-Review.Fri, Oct 2, 12:31 AM
gerritbot added a comment.Sat, Oct 3, 6:35 AM

Change #1349650 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/CodeMirror@master] codemirror.visualEditorHighlight.less: strikethrough

https://gerrit.wikimedia.org/r/1349650

gerritbot added a project: Patch-For-Review.Sat, Oct 3, 6:35 AM
gerritbot added a comment.Sat, Oct 3, 7:14 AM

Change #1349650 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] codemirror.visualEditorHighlight.less: strikethrough

https://gerrit.wikimedia.org/r/1349650

Maintenance_bot removed a project: Patch-For-Review.Sat, Oct 3, 7:31 AM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.23; 2026-10-06).Sat, Oct 3, 8:00 AM
MusikAnimal renamed this task from Underline/strike text wrapped in <u>, <ins>, <s>, and <del> tags in CodeMirror to Strike text wrapped in <s> and <strike> tags in CodeMirror.Wed, Oct 7, 3:50 PM
MusikAnimal closed this task as Resolved.
MusikAnimal updated the task description. (Show Details)
MusikAnimal subscribed.

Reworded to reflect reality. See discussion at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CodeMirror/+/1340535/comments/d5cca3b8_96805fcb

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits