Page MenuHomePhabricator

Clicking on the watchlist labels input makes the whole popover shrink
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

Clicking on the watchlist labels input makes the whole popover shrink and lose its min-width. Also, the green icons turn white.

The shrinking is better reproduced on the history pages: https://www.mediawiki.org/w/index.php?title=MediaWiki&action=history&watchstarpopover=1

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Vesperio_ofc subscribed.

Hii,
I'd like to work on this task

Hello @SerDIDG ,
Can you please provide me the more details regarding this what we want which make me more clarity about it ,
and the repository over which I have to work...

In T437769#12314233, @CoderAnimeshPathak wrote:

Hello @SerDIDG ,
Can you please provide me the more details regarding this what we want which make me more clarity about it ,
and the repository over which I have to work...

It's in a new upcoming feature in core: https://gerrit.wikimedia.org/g/mediawiki/core/+/master/resources/src/mediawiki.watchstar.popover. See T415173.

You can test it by using the watchstarpopover=1 URL query parameter, for example, on testwiki.

Change #1340492 had a related patch set uploaded (by CoderAnimeshPathak; author: CoderAnimeshPathak):

[mediawiki/core@master] watchstar: Prevent popover and icon from shrinking on interaction

https://gerrit.wikimedia.org/r/1340492

I think the problem is not in the particular styles that the patch above tries to fix, but rather in some mechanism when a Codex input receives focus. As you can see on this video, style priorities are shifted.

Ohk Sure @SerDIDG ,
I have just update its dimentions and force them to don't be shrink and changes the sizes on clicks.
Thank you...

Change #1340492 abandoned by CoderAnimeshPathak:

[mediawiki/core@master] watchstar: Prevent popover and icon from shrinking on interaction

https://gerrit.wikimedia.org/r/1340492

Samwalton9-WMF moved this task from Inbox to To be estimated on the Moderator-Tools-Team board.
jsn.sherman set the point value for this task to 2.Tue, Sep 15, 2:33 PM
jsn.sherman moved this task from To be estimated to Estimated on the Moderator-Tools-Team board.

Change #1342256 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/core@master] watchstar: Make popover style overrides beat Codex base styles

https://gerrit.wikimedia.org/r/1342256

Change #1342256 merged by jenkins-bot:

[mediawiki/core@master] watchstar: Make popover style overrides beat Codex base styles

https://gerrit.wikimedia.org/r/1342256

Samwalton9-WMF moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.
Samwalton9-WMF subscribed.

No longer reproducible on testwiki.