Page MenuHomePhabricator

🔬 Merge all of the GitHub Actions Dependabot updates for queryservice-updater
Closed, ResolvedPublic

Description

Look at all of the open PRs in: https://github.com/wbstack/queryservice-updater/pulls?q=is%3Apr+state%3Aopen+label%3Adependencies+label%3Agithub_actions

For each PR:

  • Check the release notes of the dependency being updated (e.g for any breaking changes or required actions)
  • Check the PR is up-to-date with the latest commit on main
  • Check CI is passing
  • If all checks are okay, approve and merge the PR into main

Once all Dependabot PRs are merged:

  1. Update the CHANGELOG
  2. Manually create a new tag on the latest commit following the same format as previously used
  3. Open a PR for staging/local in the wbaas-deploy repo to use the image created by the newly updated GitHub Actions pipeline
  4. Ship this new image to staging. Check staging works and there isn't a spike in errors.
  5. Repeat steps 3. and 4. for production

For any Dependabot PRs that can't be merged (e.g. due to failing checks, complex additional dependencies, changes required to handle breaking changes, etc.) we should open a separate ticket in the Engineering Backlog column and skip the PR. If you see an easy, quick, way to resolve the issue, go ahead - use your judgement though.

When this task is done, it should be moved to the Done column on the Kanban board and not moved back to the parent board. New versions of this task will be created in the future.

PRs:

Deploy PRs:

Event Timeline

End of day note: After fixing CI green, I merged all the green PRs. one is left which is red due to a linting error and can be fixed before the Changelog update.

After the reviewing the one left failing PR a little longer today, I realized to make it pass will mean making a change on https://github.com/wbstack/queryservice-updater/blob/main/Dockerfile#L32. I felt like this deserves a little chat in the team on how we prefer to make this linting update. Should we change the docker file to make it pass CI or should we suppress the error and merge the bump?

So I will move forward with deploying the other bumps for now.

I assume the failing PR that you left is https://github.com/wbstack/queryservice-updater/pull/158?

As this ticket will move to Done soon, and the PR will be left around, I think a comment on the PR would be useful to explain why the PR checks failed, and what you think the possible solutions are.

My 2 cents after a quick look is that we should probably listen to the linter and use ids for the USER line (I'm happy to add this as a reply on the PR once there is a comment).

P.S. make sure to copy the "permalink" from GitHub to Dockerfile#l32 so that it always points to the correct line (e.g. https://github.com/wbstack/queryservice-updater/blob/c11d1f3d75cafa54f5afa6471284d43cad8db39d/Dockerfile#L32) :)

dang removed dang as the assignee of this task.
dang subscribed.