Page MenuHomePhabricator

Decide filter count infochip behavior
Open, Needs TriagePublic

Description

T436508: Separating combinable and distinct case filters updated the filter set in preparation for T437183: Likely socks queue. As part of that feature work, 1. all filters were normalized to "filtering out" (ie. updating the "show cases w/o edits" filter to "hide cases w/o edits" and enabling that by default) and 2. the infochip was updated to denote the number of filters applied as opposed to the number of filters changed from the default. 1 maintains parity with existing functionality but 2 updated the behavior of the infochip count and CUs flagged that this behavior was unexpected and/or unclear.

We should decide if we want to keep the filter count infochip functionality as is (count of filters enabled) or if we want to try and support the original diff count functionality alongside the new queue views. The complexity comes from the queues being implemented, as those apply multiple filters by default (eg. sockpuppets queue applies 6 filters). It's not as clear what filters are/aren't being modified.

cc @OKryva-WMF @KieranMcCann-WMF @neriah @Dreamy_Jazz

Event Timeline

To me the chip number indicates how far you are away from the default view, and so if you no longer see cases this is a hint there may be more if you reduce that number

What the view is with no chip icon number could be unclear, but I'd suggest that this is always the filter settings that provide the "all view". So to me the sockpuppet queue still shows "6" in the chip text and "all" shows 0.

I say that because to me loading Special:AbuseReview without any queue shouldn't tell you your view is different to the default with this number. If there are filters enabled by default in the "all" queue, then these should be re-worked such that the filter is considered disabled in the all view (so checkbox is not checked)

To me the chip number indicates how far you are away from the default view, and so if you no longer see cases this is a hint there may be more if you reduce that number

+1

Change #1341349 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/CheckUser@master] SI: Exclude default filter from active filter count

https://gerrit.wikimedia.org/r/1341349

Change #1341349 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] SI: Exclude default filter from active filter count

https://gerrit.wikimedia.org/r/1341349

@Dreamy_Jazz, I assume this can be marked as resolved?

Maybe, though I merged your patch without really discussing it much as a group in the team. Maybe let's leave it open for now, given that the same questions might be asked about the "likely sockpuppets" queue having the infochip already display a number in the default view