Page MenuHomePhabricator

iframe code always embeds File:DuckandC1951.ogg
Closed, ResolvedPublic

Description

The iframe code to share a video always embeds File:DuckandC1951.ogg, regardless of the video that's currently viewed.

Also, the "copy code" button doesn't actually copy anything. I'm assuming these issues are related, so I'm grouping them into this report.

Steps to reproduce

Actual results

  1. Nothing is copied to the clipboard
  2. The iframe code that is displayed contains another video:

<iframe src="//en.wikipedia.org/wiki/File:DuckandC1951.ogg?embedplayer=yes" width="1024" height="768" frameborder="0" ></iframe>

Expected results

  1. The iframe code is copied to the clipboard.
  2. The iframe code contains the right video, not DuckandC1951.ogg.

Additional information

Firefox 16.0.2 on openSUSE 12.2


Version: unspecified
Severity: normal

Details

Reference
bz41820

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:44 AM
bzimport set Reference to bz41820.

mdale wrote:

Was related to jQuery scope issue. Also added support to always use commons as the iframe embed host ( instead of the local wiki ) if the asset is coming from commons.

https://gerrit.wikimedia.org/r/32056

The copy to clipboard is a browser limitation. Flash supports clipboard access. We can add in flash zeroclipboard: http://code.google.com/p/zeroclipboard/ to support copy ... or just update the button to say "select embed code".

mdale wrote:

marked resolved 32056 has been merged.

Gilles triaged this task as Unbreak Now! priority.Dec 4 2014, 10:10 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Needs Triage.Dec 4 2014, 11:23 AM