Page MenuHomePhabricator
Create Task
Maniphest T43838

Make it possible for users without the editinterface right to edit the AbuseFilter messages
Open, Stalled, LowPublicFeature
Actions

Description

Currently, the AbuseFilter warnings are all in the MediaWiki: namespace. As a result, they can only be edited by users with the "editinterface" right. However, on some wikis (such as English Wikipedia), the "abusefilter-modify" right is given to non-admins (in the case of English Wikipedia, it's not even part of the admin package). These messages should be considered an extension of the filters, and not part of the interface. Probably, the easiest implementation would be to create a new namespace for these.

Version: unspecified
Severity: enhancement

Details

Reference
bz41838

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 12:46 AM
• bzimport added a project: AbuseFilter.
• bzimport set Reference to bz41838.
• bzimport added a subscriber: Unknown Object (MLST).
OdMishehu created this task.Nov 6 2012, 10:20 PM
• werdna unsubscribed.Dec 10 2014, 5:45 PM
DannyS712 subscribed.EditedSep 14 2019, 5:29 AM

A new namespace would probably not be the best idea. Maybe a hook when checking namespace protection?

DannyS712 claimed this task.EditedDec 1 2019, 8:28 AM
DannyS712 added a project: Platform Engineering.

Proposal:
In core, PermissionManager::checkSpecialsAndNSPermissions adds a hook to allow bypassing namespace protection.
In AbuseFilter, on the hook call, say to skip the check if:

  • The user has abusefilter-modify rights
  • The namespace is NS_MEDIAWIKI
  • The title matches abusefilter-(?:disallowed|warning).*

Tagging Platform Engineering as a feature request for review

Restricted Application added a project: User-DannyS712. · View Herald TranscriptDec 1 2019, 8:28 AM
Anomie moved this task from Inbox to Triage Meeting Inbox on the Platform Engineering board.Dec 2 2019, 4:00 PM
Maintenance_bot moved this task from Unsorted to Abuse Filter on the User-DannyS712 board.Dec 2 2019, 4:15 PM
DannyS712 mentioned this in T36856: Since 1.17, you can't override page permission errors by a hook.Dec 5 2019, 4:11 AM
DannyS712 added a subscriber: Anomie.Jan 12 2020, 10:02 PM

@Anomie I saw that you moved this to the "Triage Meeting Inbox" over a month ago - is core platform team okay with this / is adding this hook to core acceptable?

Anomie added a subscriber: WDoranWMF.Jan 13 2020, 6:22 PM

Since it's still in the inbox, it probably still needs review. @WDoranWMF, any further status?

• nnikkhoui moved this task from Triage Meeting Inbox to Volunteer Needed Tasks on the Platform Engineering board.Mar 31 2020, 8:32 PM
DannyS712 added a subscriber: • nnikkhoui.Apr 16 2020, 9:37 PM

@nnikkhoui I saw you moved it to Volunteer Needed Tasks - does that mean that the core platform team is okay with this / that adding a hook is approved?

Pppery awarded a token.Apr 17 2020, 4:23 PM
DannyS712 added a comment.Jun 6 2020, 4:24 AM
In T43838#6064261, @DannyS712 wrote:

@nnikkhoui I saw you moved it to Volunteer Needed Tasks - does that mean that the core platform team is okay with this / that adding a hook is approved?

{{ping}} @WDoranWMF @Anomie @nnikkhoui

Proc awarded a token.Sep 26 2020, 3:19 AM
Proc subscribed.
Aklapper removed subscribers: Anomie, • wikibugs-l-list.Oct 16 2020, 5:03 PM
DannyS712 changed the task status from Open to Stalled.Nov 23 2020, 2:21 AM
DannyS712 added a subscriber: Anomie.
In T43838#6198428, @DannyS712 wrote:
In T43838#6064261, @DannyS712 wrote:

@nnikkhoui I saw you moved it to Volunteer Needed Tasks - does that mean that the core platform team is okay with this / that adding a hook is approved?

{{ping}} @WDoranWMF @Anomie @nnikkhoui

Marking as stalled to make it clear this is awaiting approval from core platform team

Anomie unsubscribed.Nov 23 2020, 6:25 PM
Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 11:14 AM
DannyS712 removed DannyS712 as the assignee of this task.Oct 5 2023, 9:45 PM

I'm sorry that I haven't handled this task. I recently returned from a long bout of unexpected inactivity, and while I plan to resume my contributions here on Phabricator its unfair to claim tasks that I might not work on when others may be interested in handling them. I'm removing myself as the assignee in a batch-action, but if someone feels that I really should be the one to handle this task feel free to re-assign me and I'll take a look.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL