Page MenuHomePhabricator

Cache expensive elements in Special:TimedMediaHandler
Closed, ResolvedPublic

Description

Currently, the performance of Special:TimedMediaHandler is apparently bad enough that we need to severely restrict who has access to it. We need to instead cache it well enough so that it can be available to anonymous users.


Version: unspecified
Severity: normal

Details

Reference
bz41854

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:47 AM
bzimport set Reference to bz41854.

Line 155 onwards in SpecialTimedMediaHandler:

'img_media_type = "VIDEO" AND (' . $condition . ')',

img_media_type isn't currently indexed in core (maybe it should be?)

Also, $condition may also not be, depending on it's contents

array( 'transcode_key' => $key ),

transcode_key from the transcode table isn't indexed (well, it is, as a second column, but if we're not using that one, it doesn't help)

That one can/should be trivially fixed by adding an extra index on it.

Table should be small enough to add the index straight off

(In reply to comment #2)

array( 'transcode_key' => $key ),

transcode_key from the transcode table isn't indexed (well, it is, as a second
column, but if we're not using that one, it doesn't help)

That one can/should be trivially fixed by adding an extra index on it.

Table should be small enough to add the index straight off

https://gerrit.wikimedia.org/r/32236

I'm not sure this is actually fixed yet. I just addressed one issue

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:27 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:22 AM