Page MenuHomePhabricator

Combowiki: Add more pay the fee functionality
Closed, ResolvedPublic

Description

The donate wiki version has a dynamic fee amount based on the amount of the donation selected:

I'll generously add $0.35 to cover the transaction fees so you can keep 100% of my donation.

Event Timeline

Cstone triaged this task as High priority.Sep 22 2026, 5:27 AM
Cstone added a project: fr-combowiki.

Change #1344979 had a related patch set uploaded (by Dmiranda; author: Dmiranda):

[mediawiki/extensions/DonationInterface@master] Show the suggested fee amount in the ComboWiki pay the fee checkbox

https://gerrit.wikimedia.org/r/1344979

Hi @Cstone! The patch for this ticket is ready for review and can be found here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1344979

Changes include:

  • The fee checkbox now shows the actual fee ("I'll generously add $2.00 to cover the transaction fees…") and updates as the amount changes. It uses the same calculation as calculateFee() on the donate wiki: 4% with per-currency minimums, rounded to whole units for currencies without cents.
  • Checking the box now adds the fee to the amount charged, for card, Apple Pay, Google Pay, PayPal and Venmo.
  • The box is hidden when the amount plus the fee would go over the max, like on donate wiki.
  • Translations for 25 languages come from Template:PTF_Text/Default.

I have tested out making a donation on gravy sandbox and can confirm that the fee gets counted if the user chooses to cover it:

Screenshot 2026-09-25 at 3.29.18 PM.png (2,482×256 px, 64 KB)

I do have the following questions which I don't think are blockers, but I was wondering if you would happen to know the answer:

  • For one-time PayPal and Venmo, the monthly convert modal shows the total with the fee (Ex: $52 for a donation of $50, plus the $2 fee) on the decline button. Accepting the monthly ask charges the ask (EX: $8.50, for a one time donation of $52), instead of starting off with the one time donation of $52 and then charging $8.50 from there on out. This matches the donate wiki, but I wanted to double check if this was expected?
  • There were around 6 languages that I did not find the translation for. (ar, gl, lb, mk, zh-hans, zh-hant) From my understanding, these are going to show the old message until translators update them to reflect the new message that we added which shows the donation fee. Just wanted to double check if this was OK?

If there are any other questions or feedback, let me know. Thanks!

Change #1344979 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Update donation fee message and functionality

https://gerrit.wikimedia.org/r/1344979

thanks @dmiranda ! I merged this then saw you questions :) but:

  • Yeah the pre payment monthly convert flow works differently than the post payment. We can't do the one time and monthly in this situation as we haven't completed the payment yet. For the post payment monthly convert we charge the one time first and then have that token available to also add a monhtly if the donor chooses it.
  • Yeah that's fine. Translatewiki also shows that there has been a change and we'll do our own QA for each new language we add and can catch it then if it's still there.
XenoRyet set Final Story Points to 4.