Page MenuHomePhabricator

[testwiki wmf.21] Daily reads - interest selector dialog is not displayed in viewport
Closed, ResolvedPublicBUG REPORT

Description

  • Tested on real devices - iPhone 11 and Samsung Galaxy S8
  • the issue is present in Chrome mobile emulator too - Android/Pixel look fine and iPhone displays the issue
  • the real Android device presents the issue in a slightly better way than on the iPhone

Steps to replicate the issue

  • on iPhone as a user with &mpo=de-1-3-1-specialhomepage-onboarding-ab-test:treatment click on the x on the baby globe Welcome screen during a new account setup
  • after clicking x, a new user lands on a screen Daily reads block displayed after Suggested edits module
  • scroll down so Daily reads are displayed in the entire view port and click on "Select interests"

What happens?:

  • the "Select interests" dialog scroll up and a user cannot move to the upper part of the dialog
  • the same issue happens when the interests have been selected and a user just returns to make different selections.

The gifs show two cases - the initial selection of interests and returning

initial selection of interestsre-selecting the interests
layout_shift interest selectors5.gif (472×957 px, 3 MB)
interest re-selection.gif (376×837 px, 823 KB)

What should have happened instead?:
Android shows correct behavior - the dialog scrolls into the viewport. Although it'd be better that the positioning would be more precise.
Click on the gif:

android interest re-selection.gif (376×837 px, 741 KB)

Software version:
testwiki wmf.21 with &mpo=de-1-3-1-specialhomepage-onboarding-ab-test:treatment

Event Timeline

Change #1345594 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] fix(Homepage): apply the body transform only when an overlay is open

https://gerrit.wikimedia.org/r/1345594

Change #1345595 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] fix(Homepage): remove the body transform for Firefox Android overlays

https://gerrit.wikimedia.org/r/1345595

Change #1345643 had a related patch set uploaded (by VolkerE; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@wmf/1.47.0-wmf.21] fix(Homepage): apply the body transform only when an overlay is open

https://gerrit.wikimedia.org/r/1345643

Change #1345594 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(Homepage): apply the body transform only when an overlay is open

https://gerrit.wikimedia.org/r/1345594

Change #1345643 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.47.0-wmf.21] fix(Homepage): apply the body transform only when an overlay is open

https://gerrit.wikimedia.org/r/1345643

Mentioned in SAL (#wikimedia-operations) [2026-09-28T21:00:37Z] <cjming@deploy1003> Started scap sync-world: Backport for [[gerrit:1345624|fix(ReadingRecommendations): reposition personalize button (T439158)]], [[gerrit:1345643|fix(Homepage): apply the body transform only when an overlay is open (T439038)]]

Mentioned in SAL (#wikimedia-operations) [2026-09-28T21:04:52Z] <cjming@deploy1003> volker-e, cjming: Backport for [[gerrit:1345624|fix(ReadingRecommendations): reposition personalize button (T439158)]], [[gerrit:1345643|fix(Homepage): apply the body transform only when an overlay is open (T439038)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-09-28T21:13:24Z] <cjming@deploy1003> Finished scap sync-world: Backport for [[gerrit:1345624|fix(ReadingRecommendations): reposition personalize button (T439158)]], [[gerrit:1345643|fix(Homepage): apply the body transform only when an overlay is open (T439038)]] (duration: 12m 47s)

There's one more issue, after the backport: With a big number of recommendations the dialog confirmation button becomes unreachable on certain mobile viewports in my testing. @Etonkovidova could you have a look and falsify/verify this?

Checked on beta - the issue is fixed. The gif below shows the correct positioning of the interest selector overlay when the selector button is clicked:

interst_selector Daily reads.gif (394×826 px, 1 MB)