Page MenuHomePhabricator
Create Task
Maniphest T439219

Have fresh script to pass shellcheck and enable in CI
Closed, ResolvedPublic
Actions

Description

Shellcheck is bash based, we should pass shellcheck on it which catch a lot of low hanging fruit and oddities in bash.

I have upgraded the shellcheck job from 0.9.0 to 0.10.0 in T439152, can add a non voting job to have it run / for review

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Pass shellcheck on bin/_fresh_versionsHasharfreshmaster+8 -7
Pass shellcheck on fresh-node scriptsHasharfreshmaster+6 -6
Zuul: [fresh] Make shellcheck voting and required before testsHasharintegration/configmaster+4 -3
Refactor mw env generation to use bash arrayHasharfreshmaster+12 -12
Pass shellcheck on tests scriptsHasharfreshmaster+46 -40
zuul: add shellcheck-non-voting to freshHasharintegration/configmaster+1 -0
jjb: add non-voting shellcheck jobHasharintegration/configmaster+8 -1
Customize query in gerrit

Related Objects

Event Timeline

hashar created this task.Fri, Sep 25, 9:02 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Sep 25, 9:02 AM
gerritbot added a comment.Fri, Sep 25, 10:04 AM

Change #1345060 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: add non-voting shellcheck job

https://gerrit.wikimedia.org/r/1345060

gerritbot added a project: Patch-For-Review.Fri, Sep 25, 10:04 AM

Change #1345061 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] zuul: add shellcheck-non-voting to fresh

https://gerrit.wikimedia.org/r/1345061

gerritbot added a comment.Fri, Sep 25, 10:04 AM

Change #1345062 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] zuul: make shellcheck voting and required before tests

https://gerrit.wikimedia.org/r/1345062

gerritbot added a comment.Fri, Sep 25, 10:05 AM

Change #1344764 had a related patch set uploaded (by Hashar; author: Hashar):

[fresh@master] Pass shellcheck on tests scripts

https://gerrit.wikimedia.org/r/1344764

gerritbot added a comment.Fri, Sep 25, 10:05 AM

Change #1344765 had a related patch set uploaded (by Hashar; author: Hashar):

[fresh@master] Pass shellcheck on bin/_fresh_versions

https://gerrit.wikimedia.org/r/1344765

gerritbot added a comment.Fri, Sep 25, 10:05 AM

Change #1345063 had a related patch set uploaded (by Hashar; author: Hashar):

[fresh@master] Pass shellcheck on fresh-node scripts

https://gerrit.wikimedia.org/r/1345063

gerritbot added a comment.Fri, Sep 25, 10:11 AM

Change #1345060 merged by jenkins-bot:

[integration/config@master] jjb: add non-voting shellcheck job

https://gerrit.wikimedia.org/r/1345060

gerritbot added a comment.Fri, Sep 25, 10:13 AM

Change #1345061 merged by jenkins-bot:

[integration/config@master] zuul: add shellcheck-non-voting to fresh

https://gerrit.wikimedia.org/r/1345061

gerritbot added a comment.Mon, Sep 28, 11:56 AM

Change #1345515 had a related patch set uploaded (by Hashar; author: Hashar):

[fresh@master] Refactor mw env generation to use bash array

https://gerrit.wikimedia.org/r/1345515

gerritbot added a comment.Tue, Sep 29, 5:53 PM

Change #1344764 merged by jenkins-bot:

[fresh@master] Pass shellcheck on tests scripts

https://gerrit.wikimedia.org/r/1344764

gerritbot added a comment.Tue, Sep 29, 6:08 PM

Change #1344765 merged by jenkins-bot:

[fresh@master] Pass shellcheck on bin/_fresh_versions

https://gerrit.wikimedia.org/r/1344765

gerritbot added a comment.Tue, Sep 29, 6:21 PM

Change #1345515 merged by jenkins-bot:

[fresh@master] Refactor mw env generation to use bash array

https://gerrit.wikimedia.org/r/1345515

gerritbot added a comment.Tue, Sep 29, 6:50 PM

Change #1345062 merged by jenkins-bot:

[integration/config@master] Zuul: [fresh] Make shellcheck voting and required before tests

https://gerrit.wikimedia.org/r/1345062

Stashbot added a comment.Tue, Sep 29, 6:55 PM

Mentioned in SAL (#wikimedia-releng) [2026-09-29T18:55:18Z] <James_F> Zuul: [fresh] Make shellcheck voting and required before tests, for T439219

Jdforrester-WMF closed this task as Resolved.Tue, Sep 29, 6:58 PM
Jdforrester-WMF assigned this task to hashar.
gerritbot added a comment.Tue, Sep 29, 7:10 PM

Change #1345063 merged by jenkins-bot:

[fresh@master] Pass shellcheck on fresh-node scripts

https://gerrit.wikimedia.org/r/1345063

Maintenance_bot removed a project: Patch-For-Review.Tue, Sep 29, 7:30 PM
hashar moved this task from Inbox to Support & Meta on the Fresh board.Thu, Oct 1, 8:52 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits