Description
The reasons for doing this include:
- That logging call requires a value from getZMapValue (and it would be useful to use another, larger value from there), but getZMapValue is O(n), and the same information can be obtained more efficiently inside orchestrate().
- That log, conceptually, is paired with the log in orchestrate(), with the message "Incoming orchestrator request"; together these 2 calls work nicely to delimit what orchestrate() does, so it's clean for both of them to live there.
A couple details to consider:
- If we move it, we might want to conditionize it on isTopLevel, so as not to increase the frequency with which it gets logged.
- We already have other log statements for the timeout and the catch (in orchestrationRoute.js), and we should add one for the preCheck condition. These are all conditions in which orchestrate() either didn't get called or did not complete in time, so conceptually it makes sense to have distinct logging messages for them.
Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)
- ...
Completion checklist
- Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist