Page MenuHomePhabricator

orchestrationRoute.js: Consider moving the "Outgoing orchestrator response" log into orchestrate()
Closed, ResolvedPublic

Description

Description

The reasons for doing this include:

  • That logging call requires a value from getZMapValue (and it would be useful to use another, larger value from there), but getZMapValue is O(n), and the same information can be obtained more efficiently inside orchestrate().
  • That log, conceptually, is paired with the log in orchestrate(), with the message "Incoming orchestrator request"; together these 2 calls work nicely to delimit what orchestrate() does, so it's clean for both of them to live there.

A couple details to consider:

  • If we move it, we might want to conditionize it on isTopLevel, so as not to increase the frequency with which it gets logged.
  • We already have other log statements for the timeout and the catch (in orchestrationRoute.js), and we should add one for the preCheck condition. These are all conditions in which orchestrate() either didn't get called or did not complete in time, so conceptually it makes sense to have distinct logging messages for them.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • ...

Completion checklist

Event Timeline

DMartin-WMF renamed this task from orchestrationRoute: Consider moving the "Outgoing orchestrator response" log into orchestrate() to orchestrationRoute.js: Consider moving the "Outgoing orchestrator response" log into orchestrate().
DMartin-WMF changed the task status from Open to In Progress.Oct 1 2026, 6:20 AM
DMartin-WMF claimed this task.
DMartin-WMF triaged this task as Medium priority.

Change #1355174 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-10-07-060824 to 2026-10-14-161253

https://gerrit.wikimedia.org/r/1355174

Change #1355174 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-10-07-060824 to 2026-10-14-161253

https://gerrit.wikimedia.org/r/1355174