Page MenuHomePhabricator
Create Task
Maniphest T439422

[Image Browsing] Carousel images should extend beyond content margins
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To
matthiasmullie
Authored By
matthiasmullie
Mon, Sep 28, 2:04 PM
Project Tags
Referenced Files
F105441740: Screenshot 2026-09-29 at 2.25.39 PM.png
Tue, Sep 29, 6:27 PM
F105277925: Screenshot 2026-09-28 at 16.03.14.png
Mon, Sep 28, 2:04 PM
F105277922: Screenshot 2026-09-28 at 16.03.07.png
Mon, Sep 28, 2:04 PM
Subscribers
Aklapper
Etonkovidova
JScherer-WMF
matthiasmullie

Description

Carousel images are meant to be visible beyond the content margins, in order to make it immediately visible that this can be scrolled horizontally.

Current:

Screenshot 2026-09-28 at 16.03.07.png (404×574 px, 158 KB)

Intended:

Screenshot 2026-09-28 at 16.03.14.png (403×524 px, 156 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Remove last bits of cuminunprivMuehlenhoffoperations/puppetproduction+0 -7
Make carousel images are visible in the marginsMatthias Mulliemediawiki/extensions/MultimediaViewermaster+1 -1
carousel: fix carousel image preload observer rootMatthias Mulliemediawiki/extensions/MultimediaViewerwmf/1.47.0-wmf.21+4 -3
Make carousel images are visible in the marginsMatthias Mulliemediawiki/extensions/MultimediaViewerwmf/1.47.0-wmf.21+1 -1
carousel: fix carousel image preload observer rootLWatsonmediawiki/extensions/MultimediaViewermaster+4 -3
Customize query in gerrit

Related Objects

Event Timeline

matthiasmullie created this task.Mon, Sep 28, 2:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Sep 28, 2:04 PM
matthiasmullie claimed this task.EditedMon, Sep 28, 2:06 PM
matthiasmullie moved this task from Committed to Code Review on the Reader Growth Team (Sprint 1 (Sep 23 - Oct 6) Q2 FY26-27) board.
matthiasmullie added a subscriber: JScherer-WMF.

Pending confirmation from @JScherer-WMF
Confirmed

gerritbot added a comment.Mon, Sep 28, 2:08 PM

Change #1345564 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/MultimediaViewer@master] Make carousel images are visible in the margins

https://gerrit.wikimedia.org/r/1345564

gerritbot added a project: Patch-For-Review.Mon, Sep 28, 2:08 PM
gerritbot added a comment.Mon, Sep 28, 2:51 PM

Change #1345564 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Make carousel images are visible in the margins

https://gerrit.wikimedia.org/r/1345564

matthiasmullie set the point value for this task to 1.Mon, Sep 28, 2:54 PM
matthiasmullie moved this task from Code Review to QA on the Reader Growth Team (Sprint 1 (Sep 23 - Oct 6) Q2 FY26-27) board.
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.22; 2026-09-29).Mon, Sep 28, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mon, Sep 28, 3:31 PM
gerritbot added a comment.Mon, Sep 28, 3:58 PM

Change #1345585 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/extensions/MultimediaViewer@master] carousel: fix carousel image preload observer root

https://gerrit.wikimedia.org/r/1345585

gerritbot added a project: Patch-For-Review.Mon, Sep 28, 3:58 PM
gerritbot added a comment.Mon, Sep 28, 7:16 PM

Change #1345627 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/MultimediaViewer@wmf/1.47.0-wmf.21] Make carousel images are visible in the margins

https://gerrit.wikimedia.org/r/1345627

gerritbot added a comment.Mon, Sep 28, 7:21 PM

Change #1345585 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] carousel: fix carousel image preload observer root

https://gerrit.wikimedia.org/r/1345585

gerritbot added a comment.Mon, Sep 28, 7:24 PM

Change #1345633 had a related patch set uploaded (by Matthias Mullie; author: LWatson):

[mediawiki/extensions/MultimediaViewer@wmf/1.47.0-wmf.21] carousel: fix carousel image preload observer root

https://gerrit.wikimedia.org/r/1345633

SherryYang-WMF triaged this task as High priority.Mon, Sep 28, 10:25 PM
gerritbot added a comment.Tue, Sep 29, 7:04 AM

Change #1345627 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@wmf/1.47.0-wmf.21] Make carousel images are visible in the margins

https://gerrit.wikimedia.org/r/1345627

gerritbot added a comment.Tue, Sep 29, 7:04 AM

Change #1345633 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@wmf/1.47.0-wmf.21] carousel: fix carousel image preload observer root

https://gerrit.wikimedia.org/r/1345633

Stashbot mentioned this in T439182: [Regression] MediaViewer hook adds 30% to Backend Pageview Timing on mobile (300 -> 400ms).Tue, Sep 29, 7:04 AM

Mentioned in SAL (#wikimedia-operations) [2026-09-29T07:04:49Z] <mlitn@deploy1003> Started scap sync-world: Backport for [[gerrit:1345626|Skip expensive work if known to be useless (T439182)]], [[gerrit:1345632|Cache extracted carousel data (T439182)]], [[gerrit:1345627|Make carousel images are visible in the margins (T439422)]], [[gerrit:1345633|carousel: fix carousel image preload observer root (T439422)]]

Stashbot added a comment.Tue, Sep 29, 7:09 AM

Mentioned in SAL (#wikimedia-operations) [2026-09-29T07:09:06Z] <mlitn@deploy1003> mlitn: Backport for [[gerrit:1345626|Skip expensive work if known to be useless (T439182)]], [[gerrit:1345632|Cache extracted carousel data (T439182)]], [[gerrit:1345627|Make carousel images are visible in the margins (T439422)]], [[gerrit:1345633|carousel: fix carousel image preload observer root (T439422)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now

Stashbot added a comment.Tue, Sep 29, 7:18 AM

Mentioned in SAL (#wikimedia-operations) [2026-09-29T07:18:28Z] <mlitn@deploy1003> Finished scap sync-world: Backport for [[gerrit:1345626|Skip expensive work if known to be useless (T439182)]], [[gerrit:1345632|Cache extracted carousel data (T439182)]], [[gerrit:1345627|Make carousel images are visible in the margins (T439422)]], [[gerrit:1345633|carousel: fix carousel image preload observer root (T439422)]] (duration: 13m 39s)

Maintenance_bot removed a project: Patch-For-Review.Tue, Sep 29, 7:31 AM
ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.21; 2026-09-22); removed: MW-1.47-notes (1.47.0-wmf.22; 2026-09-29).Tue, Sep 29, 8:00 AM
Etonkovidova moved this task from QA to Signoff on the Reader Growth Team (Sprint 1 (Sep 23 - Oct 6) Q2 FY26-27) board.Tue, Sep 29, 6:27 PM
Etonkovidova subscribed.

Checked on enwiki wmf.21 - the fix is in place:

Screenshot 2026-09-29 at 2.25.39 PM.png (800×1,394 px, 546 KB)

lwatson closed this task as Resolved.Wed, Sep 30, 1:12 PM
gerritbot added a comment.Fri, Oct 9, 10:50 AM

Change #1353890 had a related patch set uploaded (by Muehlenhoff; author: Muehlenhoff):

[operations/puppet@production] Remove last bits of cuminunpriv

https://gerrit.wikimedia.org/r/1353890

gerritbot added a project: Patch-For-Review.Fri, Oct 9, 10:50 AM
gerritbot added a comment.Fri, Oct 9, 11:21 AM

Change #1353890 merged by Muehlenhoff:

[operations/puppet@production] Remove last bits of cuminunpriv

https://gerrit.wikimedia.org/r/1353890

Maintenance_bot removed a project: Patch-For-Review.Fri, Oct 9, 11:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits