Page MenuHomePhabricator

Image Browsing: keep the carousel hide button attached to the carousel
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  1. Hide button is anchored to the div#bodyContent.content, not the carousel.
    carousel_hide_button_positioning_bug.png (940×1,834 px, 951 KB)
  1. Hide button appears transparent on hover. If you hover over the hide button, the background color appears transparent.
no hoverhover state
carousel_hide_button.png (762×650 px, 359 KB)
carousel_hide_button--hover.png (772×646 px, 361 KB)

What should have happened instead?:

  1. Hide button is anchored to the carousel.
  2. Hide button remains visible when hovered.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Bug found on production enwiki

QA instructions

Reproduce the bug on enwiki and then compare the current behavior to the patched behavior by injecting a fake banner.

Simulate a banner by pasting this in the browser console:

// fake banner, as a previous sibling of the carousel root
const root = document.getElementById('mmv-carousel-root');
const b = document.createElement('div');
b.id = 'fake-banner';
b.textContent = 'FAKE BANNER';
b.style.cssText = 'height:180px;line-height:180px;text-align:center;font-size:18px;' +
                  'background:#fbe3d6;border:2px dashed #c66';
root.parentNode.insertBefore(b, root);

carousel_hide_button_fake_banner.png (822×1,038 px, 481 KB)

Expected behavior:

current behavior (pre-fix)static positionbutton appears anchored to the banner
patched behaviorrelative positionbutton anchored to the carousel

Verify that the:

  • Hide button is visible on hover
  • Hide button is anchored to the carousel
  • Hide button doesn't scroll away or get cut off when horizontally scrolling the carousel

Event Timeline

lwatson changed the task status from Open to In Progress.Tue, Sep 29, 6:53 AM
lwatson claimed this task.

Change #1345859 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/extensions/MultimediaViewer@master] carousel: keep the hide button attached to the carousel

https://gerrit.wikimedia.org/r/1345859

Change #1345862 had a related patch set uploaded (by Matthias Mullie; author: LWatson):

[mediawiki/extensions/MultimediaViewer@wmf/1.47.0-wmf.21] carousel: keep the hide button attached to the carousel

https://gerrit.wikimedia.org/r/1345862

Change #1345863 had a related patch set uploaded (by Matthias Mullie; author: LWatson):

[mediawiki/extensions/MultimediaViewer@wmf/1.47.0-wmf.22] carousel: keep the hide button attached to the carousel

https://gerrit.wikimedia.org/r/1345863

Change #1345859 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] carousel: keep the hide button attached to the carousel

https://gerrit.wikimedia.org/r/1345859

Change #1345862 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@wmf/1.47.0-wmf.21] carousel: keep the hide button attached to the carousel

https://gerrit.wikimedia.org/r/1345862

Change #1345863 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@wmf/1.47.0-wmf.22] carousel: keep the hide button attached to the carousel

https://gerrit.wikimedia.org/r/1345863

Mentioned in SAL (#wikimedia-operations) [2026-09-29T07:39:42Z] <mlitn@deploy1003> Started scap sync-world: Backport for [[gerrit:1345862|carousel: keep the hide button attached to the carousel (T439507)]], [[gerrit:1345863|carousel: keep the hide button attached to the carousel (T439507)]]

Mentioned in SAL (#wikimedia-operations) [2026-09-29T07:43:51Z] <mlitn@deploy1003> mlitn: Backport for [[gerrit:1345862|carousel: keep the hide button attached to the carousel (T439507)]], [[gerrit:1345863|carousel: keep the hide button attached to the carousel (T439507)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-09-29T07:49:40Z] <mlitn@deploy1003> Finished scap sync-world: Backport for [[gerrit:1345862|carousel: keep the hide button attached to the carousel (T439507)]], [[gerrit:1345863|carousel: keep the hide button attached to the carousel (T439507)]] (duration: 09m 57s)

Fix on enwiki iPhone 17 iOS 26 Safari.

Large banner at the top of the Berlin article:


IMG_9443.png (1,206×2,622 px, 2 MB)

matthiasmullie set the point value for this task to 1.Tue, Oct 6, 8:08 AM