Page MenuHomePhabricator

Copy metadata copies even if nothing was selected to copy
Closed, ResolvedPublic

Description

Even if nothing was selected to be copied (by not checking any of the checkboxes) the copy button doesn't show any message or error.

I can work on this but have a few doubts as to how is such a message displayed in MW. Normally one could just do a alert( 'Nothing selected to copy' ) but alert would be weird on Wikipedia :p


Version: REL1_18-branch
Severity: trivial

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 12:57 AM
bzimport added a project: UploadWizard.
bzimport set Reference to bz41999.
bzimport added a subscriber: Unknown Object (MLST).

Hi Nischay,
I am trying to reproduce this on http://test2.wikipedia.org/wiki/Special:UploadWizard but cannot find that Copy button.
Where is it exactly? (Which of the five steps of "Learn / Upload / Release rights / Describe / Use" and what to click?)
Or is this about an old version of UW?

(In reply to comment #1)

Where is it exactly? (Which of the five steps of "Learn / Upload / Release
rights / Describe / Use" and what to click?)

This is the copy metadata feature available on the describe page. What it does is copy the metadata (eg. description,etc) from the first file to other files.

Hi Nischay,

(In reply to comment #2)

This is the copy metadata feature available on the describe page.

There is none for me (please see the URL that I pasted for a good reason).

In general: If it works for you, please always provide a full URL so we can make sure that we talk about the same thing / server / configuration.

In the meantime I've found out that this refers to custom fields added by the campaign feature; see https://www.mediawiki.org/wiki/Extension:UploadWizard/Campaigns

(In reply to comment #3)

There is none for me (please see the URL that I pasted for a good reason).

Sorry I get permission errors on that page.

Try to reproduce this on http://commons.wikimedia.org/wiki/Special:UploadWizard

Upload more than one file and at step 3 you will see a link saying "Copy information to the other upload below ..." on clicking over it the copy button appears. Uncheck all the checkboxes and you can still click on Copy.

The button should probably be disabled when all of the checkboxes are unchecked. This would be easier to do after T117784.

Change 291722 had a related patch set uploaded (by Bartosz Dziewoński):
uw.CopyMetadataWidget: Make the 'Copy' button disabled if there's nothing to copy

https://gerrit.wikimedia.org/r/291722

Change 291722 merged by jenkins-bot:
uw.CopyMetadataWidget: Make the 'Copy' button disabled if there's nothing to copy

https://gerrit.wikimedia.org/r/291722