Page MenuHomePhabricator

Update GrowthBook to include new features related to Custom Hooks implementation
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

Some functionality that we want to include when implementing Custom Hooks are related to a couple of features we are/were waiting for:

  • Something to disable/hide checklist items that GrowthBook adds automatically
  • A way to put links in the warning/error messages that Custom Hooks show

Once those feature are implemented/merged in GrowthBook, we will have to build and deploy a new image based on those commits (we don't want to wait for the next official release, it can take months). The corresponding Pull Requests for those features are the following:

Acceptance criteria

  • Staging is ready
    • Loads, can log in
    • Connections still work (Data Source > Presto Analytics Test Hive|Iceberg > View SQL Explorer)
      • Can query SELECT 1 in Presto Analytics Test Hive
      • Can query SELECT 1 in Presto Analytics Test Iceberg
    • No requests to third parties introduced (use Network tab in your browser's Developer Tools to verify)
  • Production is ready
    • Loads, can log in
    • Connections still work (Data Source > Presto Analytics Test Hive|Iceberg > View SQL Explorer)
      • Can query SELECT 1 in Presto Analytics Test Hive
      • Can query SELECT 1 in Presto Analytics Test Iceberg
    • No requests to third parties introduced (use Network tab in your browser's Developer Tools to verify)

Event Timeline

Sfaci renamed this task from Update GrowthBook to Update GrowthBook to include new features related to Custom Hooks implementation.Fri, Oct 2, 2:54 PM
Sfaci set the point value for this task to 2.
Sfaci added a project: Essential-Work.

sfaci merged https://gitlab.wikimedia.org/repos/data-engineering/growthbook/-/merge_requests/64

Updated GrowthBook to the specific commit where two relevant MRs have been merged

Change #1352033 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] Deploy GrowthBook to staging based on a specific commit

https://gerrit.wikimedia.org/r/1352033

Change #1352033 merged by jenkins-bot:

[operations/deployment-charts@master] Deploy GrowthBook to staging based on a specific commit

https://gerrit.wikimedia.org/r/1352033

Change #1352461 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] Deploy GrowthBook to staging based on a specific commit

https://gerrit.wikimedia.org/r/1352461

Change #1352461 merged by jenkins-bot:

[operations/deployment-charts@master] Deploy GrowthBook to staging based on a specific commit

https://gerrit.wikimedia.org/r/1352461

Change #1352490 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] Deploy GrowthBook to production based on a specific commit

https://gerrit.wikimedia.org/r/1352490

Change #1352490 merged by jenkins-bot:

[operations/deployment-charts@master] Deploy GrowthBook to production based on a specific commit

https://gerrit.wikimedia.org/r/1352490