Edit suggestions are being unexpectedly suppressed
Open, Needs TriagePublic
Actions

Assigned To

Authored By

	ppelberg
	Fri, Oct 2, 5:40 PM

Project Tags

Referenced Files

	F105879570: Screenshot 2026-10-02 at 3.59.42 PM.png
	Fri, Oct 2, 8:06 PM

	F105878001: Screenshot 2026-10-02 at 3.51.49 PM.png
	Fri, Oct 2, 8:06 PM

	F105878073: Screenshot 2026-10-02 at 3.51.04 PM.png
	Fri, Oct 2, 8:06 PM

	F105876953: Screenshot 2026-10-02 at 3.47.32 PM.png
	Fri, Oct 2, 8:06 PM

	F105876738: Screenshot 2026-10-02 at 3.46.14 PM.png
	Fri, Oct 2, 8:06 PM

Subscribers

Description

In T439033, @KStoller-WMF noticed edit suggestions generated by the Edit Check platform were being shown to people who were arriving to VE intent on acting on a suggestion they expressed an interest in via GrowthExperiments-Homepage.

In fixing T439033, @DLynch noticed that when someone publishes an edit suggestion they initiated via GrowthExperiments-Homepage and then opens VE on the same article afterwards, to initiate another edit session, no dit suggestions generated by the Edit Check platform were being shown to people. This task involves the work of revising this behavior.

Behavior

arrive in VE via tapping a suggested edit in newcomer homepage
notice NO "suggestion mode" suggestions are visible
publish suggested edit in VE, that you navigated to via newcomer homepage
land in "read mode"
tap "edit" on same article you edited in 1, 2, 3

Actual

notice all suggestion mode suggestions are suppressed

Expected

notice all suggestion mode suggestions are visible

NOTE: the above assumes you have Suggestion Mode enabled.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	ReviseToneInitializer: unsuppress suggestions once the growth edit is done	DLynch	mediawiki/extensions/GrowthExperiments	master	+9 -5

Customize query in gerrit

Related Objects

Mentioned Here: T412832: [QA task] Revise Tone - user editing workflows limitations
T439033: Revise Tone newcomer task shows suggestion count when it shouldn't

Event Timeline

ppelberg created this task.Fri, Oct 2, 5:40 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptFri, Oct 2, 5:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@KStoller-WMF: before editing prioritizes work on this, what (if any) questions/concerns does the proposed "expected" behavior bring up for you?

No questions or concerns! I agree that it makes sense to show edit suggestions if a person navigates back into edit the same article after completing a newcomer task.

It probably goes without saying, but if that person completes a second edit on the same page, I would also assume the second edit should NOT receive the newcomer task tags. (I assume that's the current behavior, but might be worth testing).

Maintenance_bot added a project: VisualEditor.Fri, Oct 2, 6:29 PM

Change #1348906 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/GrowthExperiments@master] ReviseToneInitializer: unsuppress suggestions once the growth edit is done

https://gerrit.wikimedia.org/r/1348906

gerritbot added a project: Patch-For-Review.Fri, Oct 2, 7:12 PM

DLynch claimed this task.Fri, Oct 2, 7:12 PM

DLynch moved this task from Incoming to Code review on the Editing-team (FY2026-27 Q2 sprint 7) board.

DLynch edited projects, added: Editing-team (FY2026-27 Q2 sprint 7); removed: Editing-team (FY2026-27 Q2 sprint 8).

Re-testing Summary:

(1)

Behavior

arrive in VE via tapping a suggested edit in newcomer homepage

notice NO "suggestion mode" suggestions are visible

Checked on enwiki wmf.22- both Revise tone and Add link structured tasks are present:

Screenshot 2026-10-02 at 3.46.14 PM.png (1,902×1,482 px, 467 KB)

Screenshot 2026-10-02 at 3.47.32 PM.png (3,022×1,756 px, 1 MB)

(2)
There are two modes Suggestions and Visual editor for Add link (Revise Tone doesn't have that)

Screenshot 2026-10-02 at 3.51.04 PM.png (1,978×1,826 px, 854 KB)

When a user decides to abandon Suggestions mode, there will be a confirmation:

Screenshot 2026-10-02 at 3.51.49 PM.png (1,948×1,338 px, 539 KB)

After switching to VE, a user won't be able to return to Suggestions mode. After switching to Reading mode, a user will be able to return back to Suggestions mode.

If a user abandons Suggestions mode and make & publish an edit via VE - the edit won't be marked with Newcomer task and Suggested: add links tags.

(3)

Revise Tone task behaves differently.

a user cannot make VE edit without explicitly selecting Revise or Decline
switching to Reading mode and returning back to Edit, won't display Revise Tone task
after returning from Reading mode to Edit and making an edit - the edit will be recieve Newcomer treatment - pos-edit drawers and will be marked with Newcomer task Suggested: revise tone (a long-known issue see T412832: [QA task] Revise Tone - user editing workflows limitations)

Tags Newcomer task Suggested: revise tone are added for non-Revise Tone edits

Screenshot 2026-10-02 at 3.59.42 PM.png (2,044×1,756 px, 371 KB)

DMburugu moved this task from Inbox to Tracking on the Growth-Team board.Mon, Oct 5, 1:19 PM

Change #1348906 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ReviseToneInitializer: unsuppress suggestions once the growth edit is done

https://gerrit.wikimedia.org/r/1348906

Maintenance_bot removed a project: Patch-For-Review.Mon, Oct 5, 7:31 PM

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.23; 2026-10-06).Mon, Oct 5, 8:00 PM

DLynch added a project: Editing QA.Mon, Oct 5, 10:24 PM

DLynch moved this task from Code review to QA on the Editing-team (FY2026-27 Q2 sprint 7) board.

Edit suggestions are being unexpectedly suppressedOpen, Needs TriagePublicActions