Page MenuHomePhabricator

Find common range box doesn't work with IPs starting with octet 2.
Closed, ResolvedPublic

Description

The updateCIDRresult function doesn't work when you have IP addresses in the "find common range" box that all belong to 2.x.x.x range


Version: unspecified
Severity: normal

Details

Reference
bz42018

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:58 AM
bzimport added a project: CheckUser.
bzimport set Reference to bz42018.

I realized I should've been more detailed with my bug report. Currently checkuser.js assumes that ranges 1.0.0.0/8 & 2.0.0.0/8 belong to IANA and should be ignored.

This is problem because some parts of 2.0.0.0/8 range are actually not reserved addresses; e.g. 2.178.0.0 - 2.178.253.255 is owned by Iran's telecommunication company.

More importantly, there are other ranges which are reserved too, and the JS is disregarding those. IMHO, the JS should NOT restrict any ranges, reserved or not. It's the user's responsibility to understand the nature of IP addresses; additionally, reserved addresses should never occur on CU log.

As a result, I submitted gerrit 32922 which removes the lines of code from checkuser.js that restrict the use of this tool to certain ranges.