Page MenuHomePhabricator

Find common range box must always flow left-to-right
Closed, ResolvedPublic

Description

As of now, "find common range" box follows the content's directionality. This is bad practice because IP address are always left-to-right.


Version: unspecified
Severity: enhancement

Details

Reference
bz42019

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:58 AM
bzimport added a project: CheckUser.
bzimport set Reference to bz42019.
Huji created this task.Nov 11 2012, 4:43 PM
Huji added a comment.Nov 11 2012, 4:56 PM

Gerrit 32920 should fix it.

Huji added a comment.Jan 7 2013, 12:09 AM

Created attachment 11596
In this screenshot, the content of CIDR box flow from right to left, therefore the text "1 2" (without quotes) look like "2 1"

I'm attaching a screenshot, for the sake of clarity of bug report, per saper's request.

Attached:

saper added a comment.Jan 7 2013, 12:17 AM

To reproduce, I switched by test wiki to:

$wgLanguageCode = "yi";

and set my user prefs to Yiddish, too.

I can confirm that the gerrit patch 32920 changes the directionality of the Javascript IP address entry box.

However, this seems inconsistent with the main CheckUser query box at the top of the form - even with this patch "127.0.0.1" entered there comes in RTL.
Which is understandable, because this fields is also used to enter usernames.

I am a CheckUser on Wikimedia projects, but on an RTL one. It seems inconsistent to me, but for the sake of a good directionality a separate input box of IP addresses should be provided? (I'd prefer a proper HTML solution, not a JavaScript trick hacking the directionality of the existing input box).

saper added a comment.Jan 7 2013, 12:21 AM

I meant I am *not* on the RTL project. I'm CU on plwiki, which is LTR only.

Huji added a comment.Jan 7 2013, 12:24 AM

Your observation is correct. The query box follows the directionality of the content, because on many RTL projects, a significant number of users have accounts that are in RTL. That is why I hesitated to change that. Of course, users can switch directionality of that box using browser features (context menu, keyboard shortcut, etc.)

However, CIDR box is solely used for IP address, and it is never needed to be in RTL.

saper added a comment.Jan 7 2013, 12:27 AM

So, the question is, shall we have a separate IP address entry box then?

Huji added a comment.Jan 8 2013, 1:28 AM

In my humble opinion, we shouldn't. It adds to confusion. Besides, RTL users are used to this phenomenon (it is not just the CU tool; the MediaWiki proper also has fields where you can enter a username or an IP address, such as on Special:Contribution and we don't have a separate IP field there, so we shouldn't have one for CU either).

Restricted Application added a project: I18n. · View Herald TranscriptJun 2 2015, 2:20 PM
MarcoAurelio moved this task from Backlog to Closed on the CheckUser board.May 9 2016, 8:57 AM
Restricted Application added a subscriber: JEumerus. · View Herald TranscriptMay 9 2016, 8:57 AM