UploadWizard broken in Safari 5
Closed, ResolvedPublic

Description

For both multi- and single-file uploads, UploadWizard gets stuck on "Getting file information and previews" on the first step. This was reported on https://commons.wikimedia.org/wiki/Commons:Village_pump and I was able to reproduce it with a VM. I did not see any errors in a Firebug Lite console.


Version: unspecified
Severity: major

Details

Reference
bz42143
bzimport set Reference to bz42143.
bzimport added a subscriber: Unknown Object (MLST).

Due to the timing reported on Commons, this seems quite likely to be a 1.21wmf4 issue (deployed earlier today). A few possible culprits here:
https://www.mediawiki.org/wiki/MediaWiki_1.21/wmf4#UploadWizard

Probably would be best for us to revert UploadWizard on Commons for now and then debug on a different server. The Flickr support included a lot of significant changes, so it may take some work to track down. I know that Safari is especially restrictive about iframes (which UploadWizard relies on), so that would be one area to investigate. I'll see about doing an un-deploy in the morning. Nischay, if you want to try doing some debugging in the meantime, that would be helpful as well.

I get the following 2 JS errors in Safari:

mw.UploadWizardUploadInterface.js line 335:
TypeError: 'undefined' is not an object (evaluating 'this.upload.file.size')

mw.UploadWizardDetails.js line 1002:
TypeError: 'undefined' is not an object (evaluating 'this.upload.file.description')

The first one is most likely related to the change at the bottom here:
https://gerrit.wikimedia.org/r/#/c/12269/26/resources/mw.UploadWizardUploadInterface.js

I'm going to try a quick fix...

OK, it's fixed and the fix is live on Commons. Verified that I was able to successfully upload a file via Safari 5. Now I should get some sleep :)

Grr.. My Safari fix broke it in Firefox :(

I rolled back the fix for Safari. Stay tuned...

OK, fixed for Safari and Firefox, deployed, and verified in both.

Gilles moved this task from Untriaged to Done on the Multimedia board.Dec 4 2014, 10:21 AM
Gilles raised the priority of this task from "High" to "Unbreak Now!".
Gilles lowered the priority of this task from "Unbreak Now!" to "High".Dec 4 2014, 11:22 AM

Add Comment