Page MenuHomePhabricator

LQT should not do any calls on Title::isValidMoveOperation unconditionally, especially when the titles are not related to threads at all
Open, MediumPublic

Description

+++ This bug was initially created as a clone of Bug #41278 +++

Query example for a moved test page[1].

0.0759 11.2M Query sandbox (16) (slave): SELECT /*
Threads::synchroniseArticleData Siebrand */ COUNT(*) FROM thread WHERE
(thread_article_id = '7474') AND (NOT (thread_article_namespace = '2' AND
thread_article_title = 'Siebrand/test2')) LIMIT 1
0.0762 11.2M Query sandbox (17) (slave): SELECT /*
Threads::synchroniseArticleData Siebrand */ COUNT(*) FROM thread WHERE
(thread_article_namespace = '2' AND thread_article_title = 'Siebrand/test2')
AND (NOT (thread_article_id = '7474')) LIMIT 1

[1] http://sandbox.translatewiki.net/w/i.php?title=User:Siebrand/test2


Version: master
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=41138

Details

Reference
bz42244

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:44 AM
bzimport set Reference to bz42244.
bzimport added a subscriber: Unknown Object (MLST).
Jdforrester-WMF lowered the priority of this task from Medium to Lowest.Aug 4 2016, 11:34 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

LiquidThreads has been replaced by StructuredDiscussions on all Wikimedia production wikis (except one, which will be done soon). It is no longer under active development or maintenance, so I'm re-classifying all open LQT tasks as "Lowest" priority.

Nemo_bis raised the priority of this task from Lowest to Medium.Aug 5 2016, 7:31 AM
Liuxinyu970226 lowered the priority of this task from Medium to Lowest.Mar 22 2019, 2:08 AM
Liuxinyu970226 added a subscriber: Liuxinyu970226.

As still no Gerrit patch to fix it

Nemo_bis raised the priority of this task from Lowest to Medium.Mar 22 2019, 1:08 PM

Title::isValidMoveOperation has been replaced with MovePage::isValidMove and MovePage::checkPermissions.

If only the "queries" feature of the debug toolbar would work, I could have easily seen if this issue is still there.