Page MenuHomePhabricator

VisualEditor: Handle percent-encoding in MWInternalLinkAnnotation
Closed, ResolvedPublic

Description

Per conversation with Gabriel, MWInternalLinkAnnotation needs to deal with percent-encoded hrefs. At least question marks (?) and percent signs (%) will be encoded. We need to decode these before presenting them to the user, encode the user input on the way out, and use href shadowing to make sure we don't change the href if the user didn't change the target (even if that would otherwise happen due to complete vs partial percent-encoding).


Version: unspecified
Severity: normal

Details

Reference
bz42298

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:48 AM
bzimport set Reference to bz42298.
Catrope created this task.Nov 20 2012, 8:03 PM

If5d22e88904d6b2c438caac403ac2d78d440b017 resolves this issue. It's still dependent on bug 41116 (which has a patch that needs merging: I5e1de9244d727641c10b6f0a89acc61afba7ecad )

I5e1de9244d727641c10b6f0a89acc61afba7ecad will not actually fix the problem. I'm cleaning up our link serialization handler right now, which should also fix this issue.

It's resolved on our end, we have bug 41116 to track the other issues.