Page MenuHomePhabricator

Can't mark new timed texts as patrolled
Open, MediumPublic

Description

How to reproduce the problem:

  1. Assign patroller rights to your account
  2. Go to https://commons.wikimedia.org/w/index.php?namespace=102&tagfilter=&hideliu=1&hidepatrolled=1&title=Special%3ARecentChanges
  3. Click a link to a newly created timed text
  4. There is no [Mark this page as patrolled] link at the page after loading

Expected behaviour:

  1. Assign patroller rights to your account
  2. Go to https://commons.wikimedia.org/w/index.php?namespace=0&tagfilter=&hideliu=1&hidepatrolled=1&title=Special%3ARecentChanges
  3. Click a link to a newly created gallery
  4. There is a [Mark this page as patrolled] at the bottom of the page

Version: unspecified
Severity: normal

Details

Reference
bz42364

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:52 AM
bzimport added a project: TimedMediaHandler.
bzimport set Reference to bz42364.
Rillke created this task.Nov 22 2012, 7:44 PM

jgerber wrote:

the fixed diff view from bug 42017 also fix this issue.

Assign patroller rights to your account

Go to https://commons.wikimedia.org/w/index.php?namespace=102&tagfilter=&translations=filter&hidepatrolled=1&title=Special%3ARecentChanges

Pick a new TimedText
(diff | hist) . . N! TimedText:United States Navy Band - Gloria al Bravo Pueblo.ogg.es.srt‎; 01:23 . . (+1,313)‎ . . ‎Cesardavidd (talk | contribs | block)‎ (←Created page with '1 00:00:16,000 --> 00:00:20,700 ¡Gloria al bravo pueblo! 2 00:00:21,000 --> 00:00:26,500 que el yugo lanzó 3 00:00:27,300 --> 00:00:31,200 la Ley respetando...')

There is still no [Mark this page as patrolled] link at the page

TheDJ added a subscriber: TheDJ.
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:39 PM
Restricted Application added subscribers: Matanya, Aklapper. · View Herald TranscriptSep 4 2015, 6:39 PM
TheDJ moved this task from To sort to TimedText on the TimedMediaHandler board.Oct 25 2015, 2:24 PM

This is because TimedTextPage subclasses Article and then overrides the view method. Instead it should probably use the ArticleContentViewCustom hook, but T111651 should also take care of the problem.

tomasz removed a subscriber: tomasz.Mar 18 2016, 5:31 PM