Can't mark new timed texts as patrolled
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Rillke
	Nov 22 2012, 7:44 PM

Description

How to reproduce the problem:

Assign patroller rights to your account
Go to https://commons.wikimedia.org/w/index.php?namespace=102&tagfilter=&hideliu=1&hidepatrolled=1&title=Special%3ARecentChanges
Click a link to a newly created timed text
There is no [Mark this page as patrolled] link at the page after loading

Expected behaviour:

Assign patroller rights to your account
Go to https://commons.wikimedia.org/w/index.php?namespace=0&tagfilter=&hideliu=1&hidepatrolled=1&title=Special%3ARecentChanges
Click a link to a newly created gallery
There is a [Mark this page as patrolled] at the bottom of the page

Version: unspecified
Severity: normal

Details

Reference: bz42364

Related Objects
Search...

Status	Assigned	Task
Open	None	T44364 Can't mark new timed texts as patrolled
Resolved	None	T44017 Diffs not working
Open	None	T111651 Convert TimedText to make use of ContentHandler
Resolved	Reedy	T145732 TimedMediaHandler should not call Article::getContent()

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:52 AM

• bzimport added a project: TimedMediaHandler.

• bzimport set Reference to bz42364.

Rillke created this task.Nov 22 2012, 7:44 PM

jgerber wrote:

the fixed diff view from bug 42017 also fix this issue.

Assign patroller rights to your account

Go to https://commons.wikimedia.org/w/index.php?namespace=102&tagfilter=&translations=filter&hidepatrolled=1&title=Special%3ARecentChanges

Pick a new TimedText
(diff | hist) . . N! TimedText:United States Navy Band - Gloria al Bravo Pueblo.ogg.es.srt‎; 01:23 . . (+1,313)‎ . . ‎Cesardavidd (talk | contribs | block)‎ (←Created page with '1 00:00:16,000 --> 00:00:20,700 ¡Gloria al bravo pueblo! 2 00:00:21,000 --> 00:00:26,500 que el yugo lanzó 3 00:00:27,300 --> 00:00:31,200 la Ley respetando...')

There is still no [Mark this page as patrolled] link at the page

• Gilles added a project: Multimedia.Nov 24 2014, 3:33 PM

Aklapper added a project: Regression.Dec 5 2014, 2:52 PM

TheDJ merged a task: T62334: Can't patrol edits in the TimedText namespace.Mar 21 2015, 8:05 PM

TheDJ added subscribers: Nemo_bis, MarkTraceur, tomasz and 4 others.

TheDJ added a project: MediaWiki-Patrolling.Mar 21 2015, 8:07 PM

TheDJ subscribed.

Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:39 PM

Restricted Application added subscribers: Matanya, Aklapper. · View Herald TranscriptSep 4 2015, 6:39 PM

Jdforrester-WMF removed a project: Multimedia.Sep 21 2015, 4:03 PM

TheDJ moved this task from To sort to TimedText on the TimedMediaHandler board.Oct 25 2015, 2:24 PM

This is because TimedTextPage subclasses Article and then overrides the view method. Instead it should probably use the ArticleContentViewCustom hook, but T111651 should also take care of the problem.

TheDJ added a subtask: T111651: Convert TimedText to make use of ContentHandler.Oct 26 2015, 10:23 AM

TheDJ added a project: TimedMediaHandler-TimedText.Oct 26 2015, 8:35 PM

tomasz unsubscribed.Mar 18 2016, 5:31 PM

MarkTraceur unsubscribed.Jan 27 2017, 10:16 PM

Aklapper removed a project: TimedMediaHandler.Nov 7 2019, 4:03 PM

bvibber moved this task from Backlog to Major maintenance on the TimedMediaHandler-TimedText board.Jul 2 2025, 7:47 PM