Page MenuHomePhabricator

VisualEditor: Clean up meta nodes
Closed, ResolvedPublic

Description

For after December:

  • consolidate 'type': 'metaInline' / 'metaBlock' into 'type': 'meta'
  • get rid of ve.{ce,dm}.Meta{Inline,Block}Node
  • create ve.dm.MetaNode with converter stuff but don't inherit ve.dm.LeafNode
    • eventually integrate that into the new node API

Version: unspecified
Severity: normal

Details

Reference
bz42398

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:55 AM
bzimport set Reference to bz42398.
Catrope created this task.Nov 23 2012, 8:23 PM

Turns out this could only be fixed partially. Consolidating metaBlock and metaInline was not possible and will have to wait until the node API rewrite, so I removed ce.Meta{Block,Inline}Node in https://gerrit.wikimedia.org/r/39847 and wrote up some ideas for the node API rewrite at https://www.mediawiki.org/wiki/User:Catrope/Node_API

This is fixed in gerrit 39847 which is now merged; will be deployed as part of the 2013-01-16 release cycle.