Page MenuHomePhabricator

Disabling desktop view is broken
Closed, ResolvedPublic

Description

Author: afeldman

Description:
If a user on the mobile site using a normally redirected browser views an article in desktop mode, and then attempts to switch back to mobile with the link at the bottom of every page, they are still left with a cookie that bypasses the mobile redirect. Any normal link to wikipedia takes them to the desktop site only.

This has been tested on ios 5.1 and 6.0.1 devices.


Version: unspecified
Severity: major

Details

Reference
bz42480

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz42480.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Nov 27 2012, 5:33 PM

Just confirmed with stock browser and chrome on Android 4.1.1, although I cannot replicate the problem in my iOS 6.0 simulator. Something must've gone amiss with the JS that unsets the cookie.

It looks like when the concept of ResourceLoader 'targets' was introduced, all RL modules in MobileFrontend were given a target of 'mobile' - which is incorrect for the JS that unsets the stopMobileRedirect cookie (it should only ever load on the desktop site). I suspect this is what is causing the issue. Fixed in https://gerrit.wikimedia.org/r/#/c/35422/

(In reply to comment #2)

Fixed in https://gerrit.wikimedia.org/r/#/c/35422/

Status Merged

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptJan 28 2016, 6:10 PM