Page MenuHomePhabricator

Don't run WRITE operations in ORMRowTest when testing on a Client instance
Closed, ResolvedPublic

Description

From E-Mail discussion:

Approach A:
"We could override the relevant test functions to skip the test if run on a
client setup. That detection could be implemented by defining a constant in
WikibaseClient.php (and a different constant in Wikibase.php). E.g. WB_CLIENT
and WB_REPO, or some such."

Approach B:
"Alternatively, split off the write tests from the read tests, and put the write
test into the repo extension. ORMRowTest could take a flag in the constructor,
telling it whether write operations should be tested."


Version: unspecified
Severity: normal

Details

Reference
bz42494

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:02 AM
bzimport set Reference to bz42494.

Verified in Wikidata demo sprint 25

Restricted Application added a project: Wikidata. · View Herald TranscriptJan 28 2016, 6:10 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald Transcript