Page MenuHomePhabricator

ExternalChangesLine technical debt
Closed, ResolvedPublic

Description

ExternalChangesList has no documentation on what it's supposed to be and class-orientated (ie everything is static). It also has a 120+ line method that should probably be split up.


Version: master
Severity: normal
Whiteboard: u=dev c=backend p=0

Details

Reference
bz42507

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:03 AM
bzimport set Reference to bz42507.
bzimport added a subscriber: Unknown Object (MLST).

From the looks of it, it's a utility class for constructing changes entries on on RecentChanges and the watchlist. Unit testing this will probably just be a bunch of regular expressions against the output, but we should have that anyway.

Yes. Looks like this code has not been improved upon. Also still lacks tests for basically everything.

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
JanZerebecki claimed this task.
JanZerebecki subscribed.

Doesn't exist anymore.