Page MenuHomePhabricator

Code coverage extremely low - technical debt
Closed, ResolvedPublic

Description

Client currently has an apparent test coverage of 16%: http://wikidata-docs.wikimedia.de/testcoverage/phpcoverage/20121127/extensions_Wikibase.html

Many files are not even touched during test execution and are thus omitted. Real coverage is probably closer to 5%.

That's some serious technical debt we're building up, plus a rather big risk with regards to not catching bugs before deployment.

Details

Reference
bz42510

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 1:03 AM
bzimport set Reference to bz42510.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 11518
Sad client is very sad

Attached:

What is the current status there?

Idk, our in-house coverage reporting is broken and I'm not able to run coverage myself without getting >9000 errors due to the nice spaghetti properties of the stuff in Wikibase.git. Presumably the coverage is up, though still having serious gaps.

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Krinkle set Security to None.

PHPUnit just gave me 79.18% code lines coverage on client. Worst offenders are UpdateRepo/, modules/, recentchanges/.

Addshore updated the task description. (Show Details)Dec 4 2015, 1:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 4 2015, 1:09 PM
Addshore closed this task as Resolved.Dec 4 2015, 1:10 PM
Addshore claimed this task.
Addshore added a subscriber: Addshore.

So our coverage is not as bad as when this task was first opened.
And we have T88434 to track coverage reports
So I will close this! :D

At least the client coverage is not. I wonder about the average though...