Page MenuHomePhabricator

Diff pages of archive pages contain broken link to its revisions
Closed, ResolvedPublic

Description

This is about pages like https://en.wikipedia.org/w/index.php?title=Special:Undelete&target=pagename&timestamp=20121201000000&diff=prev

Links "Revision as of xxx" are broken. This can points to respective https://en.wikipedia.org/w/index.php?title=Special:Undelete&target=pagename&timestamp=20121201000000 page however.

Steps to replicate the issue (include links if applicable):

  • Delete any page with two or more versions
  • Go to Special:Undelete of that page (by clicking "view n deleted version" on the delete success page)
  • Open a (diff)
  • The "Revision as of <timestamp>" links are pointing to the real page, but should point to Special:Undelete of that specific version instead (like the timestamp on the history list on Special:Undelete/<page> before does).

Version: 1.21.x
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:10 AM
bzimport set Reference to bz42608.
bzimport added a subscriber: Unknown Object (MLST).

As I cannot access such pages, what exactly is "broken" (what do the links point to and what shoyuld they point to)?

(In reply to comment #1)

As I cannot access such pages, what exactly is "broken" (what do the links
point to and what shoyuld they point to)?

For a deleted row:

+--------------+------------+---------+---------------------------------+---------+--------------+----------------+---------------+----------+-----------+------------+------------+--------+------------+--------------+---------------------------------+-------------------+------------------+

ar_namespacear_titlear_textar_commentar_userar_user_textar_timestampar_minor_editar_flagsar_rev_idar_text_idar_deletedar_lenar_page_idar_parent_idar_sha1ar_content_formatar_content_model

+--------------+------------+---------+---------------------------------+---------+--------------+----------------+---------------+----------+-----------+------------+------------+--------+------------+--------------+---------------------------------+-------------------+------------------+

8Ipboptions以“-”为内容创建页面1Liangent20120905044728058113011706za6z27cqk2qatlebqsiz85czbjf3rdNULLNULL

+--------------+------------+---------+---------------------------------+---------+--------------+----------------+---------------+----------+-----------+------------+------------+--------+------------+--------------+---------------------------------+-------------------+------------------+

it points to index.php?title=MediaWiki:Ipboptions&oldid=58 and should point to index.php?title=Special:Undelete&target=MediaWiki:Ipboptions&timestamp=20120905044728

Umherirrender renamed this task from Diff pages of archive pages contain some broken links to Diff pages of archive pages contain broken link to its revisions.Jan 5 2023, 9:09 PM
Umherirrender updated the task description. (Show Details)
Umherirrender removed a subscriber: wikibugs-l-list.

Change 879867 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] specials: Fix links to revisions in diff on Special:Undelete

https://gerrit.wikimedia.org/r/879867

Change 879867 merged by jenkins-bot:

[mediawiki/core@master] specials: Fix links to revisions in diff on Special:Undelete

https://gerrit.wikimedia.org/r/879867

Change 899595 had a related patch set uploaded (by Jdlrobson; author: Umherirrender):

[mediawiki/core@REL1_40] specials: Fix links to revisions in diff on Special:Undelete

https://gerrit.wikimedia.org/r/899595

Change 899595 merged by jenkins-bot:

[mediawiki/core@REL1_40] specials: Fix links to revisions in diff on Special:Undelete

https://gerrit.wikimedia.org/r/899595