Page MenuHomePhabricator

Placeholder for bugs related to security audit of CLIENT
Closed, ResolvedPublic

Description

Can't find the correct bug, using this as a placeholder for now.

There are several bugs reported in an email. This lists the issues and fixes
for the client.

./client/includes/store/sql/SiteLinkRemoteTable.php

  • Please intval $item->getId()->getNumericId() before concating into

sql Line 108


Version: unspecified
Severity: major

Details

Reference
bz42627

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:11 AM
bzimport set Reference to bz42627.

Change I67cb1ba9: Added casts to numeric id in EntityId

The call to getNumericId() should not be able to return anything except an integer.

jeblad: I don't understand what is meant by "Can't find the correct bug, using this as a placeholder for now". That there should be a bug report already?
If so, it might be in the "Security" product instead.

Verified in Wikidata demo sprint 26