Redirect category (Rcat) templates on redirect pages no longer render text on Diff pages of redirect
Closed, ResolvedPublic

Description

When redirect category (Rcat) templates are placed on redirect pages, they no longer render text on the Diff pages of the redirect. It is hoped that this is to resolve bug 14323, which asks for text to be rendered directly on redirects. In a recent discussion on that bug page, it came out that the Rcat text was removed from Diff pages "to standardize with the article display". Is that the case? If so, how does removing Rcat text from Diff pages standardize those pages with article Diff pages that show the complete article below the Diff panels? The Rcat text needs to be displayed, either directly on redirects (the preferred way), or the text should be displayed as it was before: on Diff pages. Thank you very much!


Version: 1.21.x
Severity: normal

bzimport added a subscriber: Unknown Object (MLST).
bzimport set Reference to bz42642.
Paine_Ellsworth created this task.Via LegacyDec 3 2012, 5:36 AM
Aklapper added a comment.Via ConduitDec 3 2012, 11:27 AM

Brad: Could you elaborate your comment from bug 14323 comment 21 here, if possible?

Anomie added a comment.Via ConduitDec 3 2012, 2:37 PM

The change was made in Ic3c2d6cf with the comment "Show redirects correctly on diff pages". Sounds to me like the reasoning was to render the redirect as is done on the standard article view, instead of parsing it as an odd ordered list at the beginning of the article.

What really needs to be done is to just fix bug 14323 already, which should encompass article views, edit previews, and diff views as well as any extensions (FlaggedRevs and TemplateSandbox are two I know of).

Thryduulf added a comment.Via ConduitDec 9 2012, 1:41 PM

Previews of redirects are also not showing any categories that the redirect is in via a template, either already or that it will be in if the edit is saved.

These categories used to be shown, the change that broke this presumably occurring at the same time as the above.

Paine_Ellsworth added a comment.Via ConduitDec 13 2012, 1:24 AM

(In reply to comment #3)

Previews of redirects are also not showing any categories that the redirect
is
in via a template, either already or that it will be in if the edit is
saved.

These categories used to be shown, the change that broke this presumably
occurring at the same time as the above.

Yes, that was working on and off for me. When the cats don't show on Preview, that's a bit agitatin'. I always figured that background changes were being made that sometimes enabled the cat preview and sometimes disabled it.

Thryduulf added a comment.Via ConduitDec 21 2012, 10:41 AM

Could this bug be behind unprintworthy redirects no longer being excluded from the search suggestions list? Or is that a separate issue?

See http://en.wikipedia.org/wiki/Help_talk:Searching#Unprintworthy_redirects_are_not_being_excluded_from_the_search_dropdown_as_expected for a bit of background on this.

gerritbot added a comment.Via ConduitJan 6 2014, 9:30 PM

Change 105829 had a related patch set uploaded by Anomie:
Move redirect rendering into WikitextContent

https://gerrit.wikimedia.org/r/105829

gerritbot added a comment.Via ConduitJan 7 2014, 10:45 PM

Change 105829 merged by jenkins-bot:
Move redirect rendering into WikitextContent

https://gerrit.wikimedia.org/r/105829

Anomie added a comment.Via ConduitJan 8 2014, 4:47 PM

Should be deployed to WMF wikis with 1.23wmf10, see https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap for the schedule.

Add Comment