Page MenuHomePhabricator

"Show error" used wrong line feed
Closed, ResolvedPublic

Description

When there is a transcode with error, clicking on "Show error" gives a javascript overlay with title "Error in transcode on ???"

This overlay is shown as one string. Something with \r and \n is wrong here (copy to WordPad shows, that there are some line feeds to make it more readable)

Maybe this is Windows depending. Thanks.


Version: unspecified
Severity: normal

Details

Reference
bz42833

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:56 AM
bzimport set Reference to bz42833.

jgerber wrote:

Can you provide a link to a file that has an error like the one you are referring to. It should be in a textarea and have newlines.

My example file is gone. Sorry. Go to a Special:TimedMediaHandler of a wiki, where you are sysop (or ask a sysop). There is maybe a section with "failed transcode" where you can look at.

The text is inside a textarea (in the overlayed dialog), which shows the text as one string. Maybe this is a Windows and Internet Explorer 8 problem.

Would love to have a testcase here.

TheDJ claimed this task.
TheDJ subscribed.

Unable to reproduce.
Best I can figure out is that the user was referring to the dialog that pops up when you click an error in the transcode table.

Screen Shot 2015-10-25 at 15.43.48.png (368×704 px, 104 KB)

I tested this on IE11/Win8 and I did not find the results the user described. This part did get a rewrite at some point, so possibly was fixed back then.