Page MenuHomePhabricator

ApiMain assumes MWException
Closed, ResolvedPublic

Description

ApiMain.php, line 373:

} catch ( Exception $e ) {

line 380:

if ( $wgLogExceptionBacktrace ) {
wfDebugLog( 'exception', $e->getLogMessage() . "\n" . $e->getTraceAsString() . "\n" );
} else {
wfDebugLog( 'exception', $e->getLogMessage() );
}

Since getLogMessage() is defined MWException, if Exception caught is not MWException (which is allowed by catch), we get a call to undefined method fatal.


Version: 1.21.x
Severity: normal

Details

Reference
bz42949

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:03 AM
bzimport added a project: MediaWiki-API.
bzimport set Reference to bz42949.
MaxSem created this task.Dec 11 2012, 1:47 PM

Gerrit change 38074

[ Bug assigned to code submitter ]

Change merged.